DevTools: Add popover for snapshot canvas log.

Add popover for snapshot canvas log.

Review URL: https://codereview.chromium.org/320423004

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175976

[malch, 2014-06-11 12:47:23]

Please take a look.

[caseq, 2014-06-11 16:03:22]

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/co...
File Source/devtools/front_end/components/ObjectPopoverHelper.js (right):

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/components/ObjectPopoverHelper.js:36: * @param
{function(!Element, function(!WebInspector.RemoteObject, boolean=,
!Element=):undefined, string):undefined} queryObject
is this really necessary?

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/la...
File Source/devtools/front_end/layers/PaintProfilerView.js (right):

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/la...
Source/devtools/front_end/layers/PaintProfilerView.js:251: var logItem =
liElement.__logItem;
can you use liElement.treeElement.representedObject instead?

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/la...
Source/devtools/front_end/layers/PaintProfilerView.js:332:
this.listItemElement.__logItem = this.representedObject;
...you won't need this then.

[malch, 2014-06-11 16:32:58]

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/co...
File Source/devtools/front_end/components/ObjectPopoverHelper.js (right):

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/components/ObjectPopoverHelper.js:36: * @param
{function(!Element, function(!WebInspector.RemoteObject, boolean=,
!Element=):undefined, string):undefined} queryObject
Added it because of the lint error. Removed it.
On 2014/06/11 16:03:21, caseq wrote:
> is this really necessary?

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/la...
File Source/devtools/front_end/layers/PaintProfilerView.js (right):

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/la...
Source/devtools/front_end/layers/PaintProfilerView.js:251: var logItem =
liElement.__logItem;
On 2014/06/11 16:03:21, caseq wrote:
> can you use liElement.treeElement.representedObject instead?

Done.

https://codereview.chromium.org/328113005/diff/1/Source/devtools/front_end/la...
Source/devtools/front_end/layers/PaintProfilerView.js:332:
this.listItemElement.__logItem = this.representedObject;
On 2014/06/11 16:03:21, caseq wrote:
> ...you won't need this then.

Done.

[caseq, 2014-06-11 16:48:36]

lgtm

https://codereview.chromium.org/328113005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/layers/PaintProfilerView.js (right):

https://codereview.chromium.org/328113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/layers/PaintProfilerView.js:314: var span =
title.createChild("span");
This change is probably redundant now.

[malch, 2014-06-11 16:50:44]

https://codereview.chromium.org/328113005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/layers/PaintProfilerView.js (right):

https://codereview.chromium.org/328113005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/layers/PaintProfilerView.js:314: var span =
title.createChild("span");
We need this to properly show the popover.
On 2014/06/11 16:48:36, caseq wrote:
> This change is probably redundant now.

[caseq, 2014-06-11 17:22:07]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2014-06-11 17:23:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/malch@chromium.org/328113005/20001

[commit-bot: I haz the power, 2014-06-11 18:31:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11593)

[commit-bot: I haz the power, 2014-06-11 19:35:35]

Change committed as 175976