Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 328113004: Oilpan: make FrameLoadRequest be a stack allocated object. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: make FrameLoadRequest be a stack allocated object. Simplify this stack allocated object's handling of heap references. R=ager@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/core/loader/FrameLoadRequest.h View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look. Reduce Persistent<> churn.
6 years, 6 months ago (2014-06-11 11:11:19 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 6 months ago (2014-06-11 11:15:01 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-11 11:25:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/328113004/1
6 years, 6 months ago (2014-06-11 11:25:57 UTC) #4
haraken
LGTM
6 years, 6 months ago (2014-06-11 11:40:11 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 12:16:36 UTC) #6
Message was sent while issue was closed.
Change committed as 175953

Powered by Google App Engine
This is Rietveld 408576698