Issue 328103002: MacViews: Provide CreateNativeWidget and a stub NativeThemeMac in NativeWidgetMac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328103002: MacViews: Provide CreateNativeWidget and a stub NativeThemeMac in NativeWidgetMac (Closed)

Created:
6 years, 6 months ago by tapted

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

MacViews: Provide CreateNativeWidget and a stub NativeThemeMac in NativeWidgetMac This is to get a baseline in tests so we can track coverage of future CLs. With this CL, 182 views_unittests pass (up from 125), but that's incidental. BUG=378134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276556

Patch Set 1 #

Patch Set 2 : remove old chunk #

Patch Set 3 : cite bug #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
M	ui/native_theme/native_theme_mac.h	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	ui/native_theme/native_theme_mac.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/views/widget/native_widget_mac.mm	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM - assuming this doesn't impact blink rendering incorrectly.

6 years, 6 months ago (2014-06-11 16:06:40 UTC) #2

tapted

On 2014/06/11 16:06:40, sky wrote: > LGTM - assuming this doesn't impact blink rendering incorrectly. ...

6 years, 6 months ago (2014-06-12 03:14:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/328103002/40001

6 years, 6 months ago (2014-06-12 03:18:36 UTC) #5

Message was sent while issue was closed.

Change committed as 276556

Expand Messages | Collapse Messages