Issue 328093002: Add @@iterator for generator objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328093002: Add @@iterator for generator objects (Closed)

Created:
6 years, 6 months ago by wingo

Modified:
6 years, 6 months ago

Reviewers:
arv (Not doing code reviews), rossberg

CC:
arv (Not doing code reviews), adamk, v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -7 lines)			Patch
M	src/collection-iterator.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/generator.js	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	test/mjsunit/harmony/generators-runtime.js	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	tools/generate-runtime-tests.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

wingo

On 2014/06/11 12:24:57, rossberg wrote: > LGTM, though it's not used yet, is it? Correct; ...

6 years, 6 months ago (2014-06-11 13:50:48 UTC) #2

arv (Not doing code reviews)

LGTM I was on the fence whether to use `symbolIterator` or `InternalSymbol('Symbol.iterator')`. I think we ...

6 years, 6 months ago (2014-06-11 14:25:29 UTC) #3

wingo

6 years, 6 months ago (2014-06-12 08:53:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21797 (presubmit successful).