Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 328063003: [SyncFS] Migrate SyncWorker::Observer to SyncWorkerInterface (Closed)

Created:
6 years, 6 months ago by peria
Modified:
6 years, 6 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Migrate SyncWorker::Observer to SyncWorkerInterface. BUG=347425, 378621 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276641

Patch Set 1 : #

Patch Set 2 : Put AppStatus back #

Patch Set 3 : Fix test failures #

Patch Set 4 : Remove useless comment #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -58 lines) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 2 3 4 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.h View 1 2 3 4 chunks +14 lines, -25 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 1 2 3 4 4 chunks +29 lines, -27 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h View 1 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
peria
PTL.
6 years, 6 months ago (2014-06-11 07:04:27 UTC) #1
tzik
lgtm
6 years, 6 months ago (2014-06-11 08:42:02 UTC) #2
nhiroki
LGTM nit: s/SyncWorker::Oberser/SyncWorker::Observer/ on the CL title
6 years, 6 months ago (2014-06-11 09:14:58 UTC) #3
peria
On 2014/06/11 09:14:58, nhiroki wrote: > LGTM > > nit: s/SyncWorker::Oberser/SyncWorker::Observer/ on the CL title ...
6 years, 6 months ago (2014-06-11 09:15:43 UTC) #4
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-06-11 16:17:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/328063003/70001
6 years, 6 months ago (2014-06-11 16:19:05 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:35:04 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 20:40:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/82797) android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/12849) android_clang_dbg ...
6 years, 6 months ago (2014-06-11 20:40:09 UTC) #9
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-06-12 02:03:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/328063003/90001
6 years, 6 months ago (2014-06-12 02:06:55 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 03:45:50 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:42:03 UTC) #13
Message was sent while issue was closed.
Change committed as 276641

Powered by Google App Engine
This is Rietveld 408576698