Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 328053002: Check in win32 binaries for apache for the layout tests (Closed)

Created:
6 years, 6 months ago by Dirk Pranke
Modified:
6 years, 6 months ago
Reviewers:
ojan, brettw, scottmg, eseidel
CC:
chromium-reviews, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Check in win32 binaries for apache for the layout tests For years we have been using LigHTTPd, and it has been flaky. It appears that the native win32 apache2 port is much less flaky. This checks in the base files and .sha1s for all of the binaries and modules; we add a hook to gclient to download the files from google storage. R=brettw@chromium.org, ojan@chromium.org, scottmg@chromium.org BUG=30536 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277242

Patch Set 1 #

Patch Set 2 : prune a lot of unneeded files #

Patch Set 3 : add the --num-threads flag #

Patch Set 4 : fix perms #

Patch Set 5 : remove ctrl-z from end of OPENSSL-NEWS.txt #

Patch Set 6 : remove any other stray ^Zs and blank lines #

Patch Set 7 : fix license on remove_files... script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5406 lines, -0 lines) Patch
M .gitignore View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M DEPS View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/apache-win32/ABOUT_APACHE.txt View 1 2 3 1 chunk +277 lines, -0 lines 0 comments Download
A third_party/apache-win32/CHANGES.txt View 1 2 3 4 5 1 chunk +3072 lines, -0 lines 0 comments Download
A third_party/apache-win32/INSTALL.txt View 1 2 3 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/apache-win32/LICENSE.txt View 1 2 3 4 5 1 chunk +764 lines, -0 lines 0 comments Download
A third_party/apache-win32/NOTICE.txt View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/apache-win32/OPENSSL-NEWS.txt View 1 2 3 4 5 1 chunk +591 lines, -0 lines 0 comments Download
A third_party/apache-win32/OPENSSL-README.txt View 1 2 3 4 5 1 chunk +250 lines, -0 lines 0 comments Download
A third_party/apache-win32/README.chromium View 1 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/apache-win32/README.txt View 1 2 3 1 chunk +140 lines, -0 lines 0 comments Download
A third_party/apache-win32/README-win32.txt View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/apache-win32/bin/ApacheMonitor.exe.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/httpd.exe.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/libapr-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/libapriconv-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/libaprutil-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/libeay32.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/libhttpd.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/openssl.exe.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/php5ts.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/ssleay32.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/bin/zlib1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_alias.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_asis.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_authz_host.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_autoindex.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_cgi.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_headers.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_log_config.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_mime.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_rewrite.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/modules/mod_ssl.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/apache-win32/remove_files_not_needed_for_chromium.sh View 1 2 3 4 5 6 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
Dirk Pranke
I think this is good to go. Just landing this should have no effect; we ...
6 years, 6 months ago (2014-06-11 02:04:28 UTC) #1
ojan
rslgtm. Although, I doubt I have the right OWNERS to properly lgtm this. Thanks for ...
6 years, 6 months ago (2014-06-11 02:50:51 UTC) #2
brettw
This is 2 orders of magnitude more files than we've ever downloaded from google storage ...
6 years, 6 months ago (2014-06-11 19:33:17 UTC) #3
brettw
WE'll try this. Please be on the watch.
6 years, 6 months ago (2014-06-11 19:37:43 UTC) #4
brettw
lgtm
6 years, 6 months ago (2014-06-11 21:23:30 UTC) #5
Dirk Pranke
Okay, patchset #3 contains the minimal set of files we actually need, and this is ...
6 years, 6 months ago (2014-06-12 03:13:06 UTC) #6
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-12 18:08:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/328053002/40001
6 years, 6 months ago (2014-06-12 18:10:19 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 21:35:14 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 21:43:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/73409)
6 years, 6 months ago (2014-06-12 21:43:14 UTC) #11
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-12 22:26:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/328053002/60001
6 years, 6 months ago (2014-06-12 22:30:32 UTC) #13
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-12 23:39:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/328053002/80001
6 years, 6 months ago (2014-06-12 23:40:13 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 04:23:36 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 04:32:17 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/28651)
6 years, 6 months ago (2014-06-13 04:32:18 UTC) #18
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-13 21:41:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/328053002/100001
6 years, 6 months ago (2014-06-13 21:43:58 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-14 03:29:26 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/32478)
6 years, 6 months ago (2014-06-14 03:29:28 UTC) #22
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-14 16:23:08 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/328053002/120001
6 years, 6 months ago (2014-06-14 16:23:46 UTC) #24
Dirk Pranke
6 years, 6 months ago (2014-06-14 19:29:32 UTC) #25
Message was sent while issue was closed.
Committed patchset #7 manually as r277242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698