Issue 328033002: Move include/exclude calculations to the TransformerId class.

Issue 328033002: Move include/exclude calculations to the TransformerId class. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move include/exclude calculations to the TransformerId class. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=37250

Patch Set 2 : code review #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -73 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback.dart	View	1	2 chunks	+19 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/excluding_aggregate_transformer.dart	View	1	3 chunks	+16 lines, -32 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/excluding_transformer.dart	View	1	3 chunks	+16 lines, -36 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/foreign_transformer.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One request, but LGTM! https://codereview.chromium.org/328033002/diff/1/sdk/lib/_internal/pub/lib/src/barback/excluding_aggregate_transformer.dart File sdk/lib/_internal/pub/lib/src/barback/excluding_aggregate_transformer.dart (right): https://codereview.chromium.org/328033002/diff/1/sdk/lib/_internal/pub/lib/src/barback/excluding_aggregate_transformer.dart#newcode22 sdk/lib/_internal/pub/lib/src/barback/excluding_aggregate_transformer.dart:22: if (id.includes == null && ...

6 years, 6 months ago (2014-06-11 16:21:59 UTC) #2

nweiz

Committed patchset #2 manually as r37250 (presubmit successful).

6 years, 6 months ago (2014-06-12 01:35:17 UTC) #3

nweiz

6 years, 6 months ago (2014-06-12 01:35:37 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/328033002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/excluding_aggregate_transformer.dart
(right):

https://codereview.chromium.org/328033002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/excluding_aggregate_transformer.dart:22:
if (id.includes == null && id.excludes == null) return inner;
On 2014/06/11 16:21:59, Bob Nystrom wrote:
> How about adding .hasExclusions to TransformerId?

Done.

Expand Messages | Collapse Messages