Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1959)

Unified Diff: Source/platform/scroll/ScrollView.cpp

Issue 328023002: Layout overflow from transforms should update frame scrollbars (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: need to more explicitly prevent scrollbar update Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/frame/FrameView.cpp ('K') | « Source/platform/scroll/ScrollView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/scroll/ScrollView.cpp
diff --git a/Source/platform/scroll/ScrollView.cpp b/Source/platform/scroll/ScrollView.cpp
index 420f7c6be3a383eecde856147e93835ffdb4854e..faeeb879ae7a47d4023a78b74a926e5bfcf3d56c 100644
--- a/Source/platform/scroll/ScrollView.cpp
+++ b/Source/platform/scroll/ScrollView.cpp
@@ -31,12 +31,16 @@
#include "platform/HostWindow.h"
#include "platform/scroll/ScrollbarTheme.h"
#include "wtf/StdLibExtras.h"
-#include "wtf/TemporaryChange.h"
using namespace std;
namespace WebCore {
+ScrollView::InUpdateScrollbarsScope::InUpdateScrollbarsScope(ScrollView* view)
ojan 2014/06/11 03:04:53 Nit: This constructor doesn't really do any work.
trchen 2014/06/11 05:04:13 SGTM. I was hesitating.
+ : m_scope(view->m_inUpdateScrollbars, true)
+{
+}
+
ScrollView::ScrollView()
: m_horizontalScrollbarMode(ScrollbarAuto)
, m_verticalScrollbarMode(ScrollbarAuto)
@@ -458,7 +462,7 @@ void ScrollView::updateScrollbars(const IntSize& desiredOffset)
{
if (m_inUpdateScrollbars)
return;
- TemporaryChange<bool> inUpdateScrollbarsChange(m_inUpdateScrollbars, true);
+ InUpdateScrollbarsScope inUpdateScrollbarsScope(this);
IntSize oldVisibleSize = visibleSize();
« Source/core/frame/FrameView.cpp ('K') | « Source/platform/scroll/ScrollView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698