Issue 327963005: Remove call to updateLayerCompositingState in RenderLayer::contentChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 327963005: Remove call to updateLayerCompositingState in RenderLayer::contentChanged (Closed)

Created:
6 years, 6 months ago by abarth-chromium

Modified:
6 years, 6 months ago

Reviewers:
ojan

CC:
ojan, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, chrishtr, eae+blinkwatch, esprehn, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, Ian Vollick, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove call to updateLayerCompositingState in RenderLayer::contentChanged This call site was already trigginer a CompositingUpdateAfterCompositingInputChange. Calling updateLayerCompositingState could upgrade to CompositingUpdateRebuildTree, but there's no reason to do that eagerly. We compute whether that upgrade is necessary during the compositing update itself. BUG=343756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175939

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/327963005/1

6 years, 6 months ago (2014-06-11 02:42:38 UTC) #3

Message was sent while issue was closed.

Change committed as 175939

Expand Messages | Collapse Messages