Have Frame::navigationScheduler() return a reference

Have Frame::navigationScheduler() return a reference

Have Frame::navigationScheduler() return a reference instead of a pointer
as it can never return null. This makes the calling code look safer.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160270

[adamk, 2013-10-21 20:14:56]

lgtm

[Inactive, 2013-10-22 13:20:47]

tkent@, could you please take a look for Source/web?

[abarth-chromium, 2013-10-22 18:42:07]

source/web LGTM

[commit-bot: I haz the power, 2013-10-22 20:30:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/32793003/1

[commit-bot: I haz the power, 2013-10-22 20:30:57]

Failed to apply patch for Source/core/loader/FrameLoader.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/loader/FrameLoader.cpp
  Hunk #6 FAILED at 605.
  1 out of 8 hunks FAILED -- saving rejects to file
Source/core/loader/FrameLoader.cpp.rej

Patch:       Source/core/loader/FrameLoader.cpp
Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp
b/Source/core/loader/FrameLoader.cpp
index
ae5d5109e55cd3c42762db3cbed42ddee4bd3d7c..3bc39e401eabcb1324af7ea96eb569e8f538f4b1
100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -206,7 +206,7 @@ void FrameLoader::setDefersLoading(bool defers)
     history()->setDefersLoading(defers);
 
     if (!defers) {
-        m_frame->navigationScheduler()->startTimer();
+        m_frame->navigationScheduler().startTimer();
         startCheckCompleteTimer();
     }
 }
@@ -230,7 +230,7 @@ void FrameLoader::stopLoading()
     }
 
     // FIXME: This will cancel redirection timer, which really needs to be
restarted when restoring the frame from b/f cache.
-    m_frame->navigationScheduler()->cancel();
+    m_frame->navigationScheduler().cancel();
 }
 
 bool FrameLoader::closeURL()
@@ -258,7 +258,7 @@ void FrameLoader::didExplicitOpen()
     // from a subsequent window.document.open / window.document.write call.
     // Canceling redirection here works for all cases because document.open
     // implicitly precedes document.write.
-    m_frame->navigationScheduler()->cancel();
+    m_frame->navigationScheduler().cancel();
 }
 
 void FrameLoader::clear(ClearOptions options)
@@ -296,7 +296,7 @@ void FrameLoader::clear(ClearOptions options)
 
     m_frame->script()->enableEval();
 
-    m_frame->navigationScheduler()->clear();
+    m_frame->navigationScheduler().clear();
 
     m_checkTimer.stop();
     m_shouldCallCheckCompleted = false;
@@ -440,7 +440,7 @@ void FrameLoader::checkCompleted()
     if (m_frame->document()->loadEventStillNeeded())
         m_frame->document()->implicitClose();
 
-    m_frame->navigationScheduler()->startTimer();
+    m_frame->navigationScheduler().startTimer();
 
     completed();
     if (m_frame->page())
@@ -605,7 +605,7 @@ void FrameLoader::completed()
     RefPtr<Frame> protect(m_frame);
 
     for (Frame* descendant = m_frame->tree()->traverseNext(m_frame);
descendant; descendant = descendant->tree()->traverseNext(m_frame))
-        descendant->navigationScheduler()->startTimer();
+        descendant->navigationScheduler().startTimer();
 
     if (Frame* parent = m_frame->tree()->parent())
         parent->loader()->checkCompleted();
@@ -910,7 +910,7 @@ void FrameLoader::commitProvisionalLoad()
     history()->updateForCommit();
     m_client->transitionToCommittedForNewPage();
 
-    m_frame->navigationScheduler()->cancel();
+    m_frame->navigationScheduler().cancel();
     m_frame->editor().clearLastEditCommand();
 
     // If we are still in the process of initializing an empty document then
@@ -1373,7 +1373,7 @@ void FrameLoader::loadWithNavigationAction(const
ResourceRequest& request, const
 
     if (isLoadingMainFrame())
         m_frame->page()->inspectorController().resume();
-    m_frame->navigationScheduler()->cancel();
+    m_frame->navigationScheduler().cancel();
 
     m_provisionalDocumentLoader = m_policyDocumentLoader.release();
     m_loadType = type;

[commit-bot: I haz the power, 2013-10-22 21:09:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/32793003/100001

[commit-bot: I haz the power, 2013-10-22 22:30:42]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-10-22 23:27:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/32793003/100001

[commit-bot: I haz the power, 2013-10-22 23:28:36]

Change committed as 160270