Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: components/breakpad/app/crash_keys_win.h

Issue 327853002: Move the CrashKeysWin class to a pair of files as first step. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge refactor and testing back in. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/breakpad/app/crash_keys_win.h
diff --git a/components/breakpad/app/crash_keys_win.h b/components/breakpad/app/crash_keys_win.h
new file mode 100644
index 0000000000000000000000000000000000000000..c1a68301d62c80c52f70a9209c966cbc985eadb0
--- /dev/null
+++ b/components/breakpad/app/crash_keys_win.h
@@ -0,0 +1,66 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
Robert Sesek 2014/06/10 21:14:14 nit: blank line after
Sigurður Ásgeirsson 2014/06/11 13:19:39 Done.
+#include <map>
+#include <vector>
+
+#include "base/command_line.h"
+#include "base/synchronization/lock.h"
+#include "breakpad/src/client/windows/handler/exception_handler.h"
+
+namespace breakpad {
+
+// Fwd.
Robert Sesek 2014/06/10 21:14:14 Delete line.
Sigurður Ásgeirsson 2014/06/11 13:19:39 Done.
+class BreakpadClient;
+
+// Manages the breakpad key/value pair stash, there may only be one instance
+// of this class per process at one time.
+class CrashKeysWin {
+ public:
+ CrashKeysWin();
+ ~CrashKeysWin();
+
+ // May only be called once.
+ // |exe_path| is the path to the executable running, which may be used
+ // to figure out whether this is a user or system install.
+ // |type| is the process type, or mode this process is running in e.g.
+ // something like "browser" or "renderer".
+ // |profile_type| is a string describing the kind of the user's Windows
+ // profile, e.g. "mandatory", or "roaming" or similar.
+ // |cmd_line| is the current process' command line consulted for explicit
+ // crash reporting flags.
+ // |breakpad_client| is consulted for crash reporting settings.
+ google_breakpad::CustomClientInfo* GetCustomInfo(
+ const std::wstring& exe_path,
+ const std::wstring& type,
+ const std::wstring& profile_type,
+ CommandLine* cmd_line,
+ BreakpadClient* breakpad_client);
+
+ void SetCrashKeyValue(const std::wstring& key, const std::wstring& value);
+ void ClearCrashKeyValue(const std::wstring& key);
+
+ static CrashKeysWin* keeper() { return keeper_; }
+
+ private:
+ // One-time initialization of private key/value pairs.
+ void SetPluginPath(const std::wstring& path);
+ void SetBreakpadDumpPath(BreakpadClient* breakpad_client);
+
+ // Must not be resized after GetCustomInfo is invoked.
+ std::vector<google_breakpad::CustomInfoEntry> custom_entries_;
+
+ typedef std::map<std::wstring, google_breakpad::CustomInfoEntry*>
+ DynamicEntriesMap;
+ base::Lock lock_;
+ // Keeps track of the next index for a new dynamic entry.
+ size_t dynamic_keys_offset_; // Under lock_.
+ // Maintains key->entry information for dynamic key/value entries
+ // in custom_entries_.
+ DynamicEntriesMap dynamic_entries_; // Under lock_.
+
+ // Stores the sole instance of this class allowed per process.
+ static CrashKeysWin* keeper_;
+};
+
+} // namespace breakpad

Powered by Google App Engine
This is Rietveld 408576698