Move the CrashKeysWin class to a pair of files as first step.

components/breakpad/app/crash_keys_win.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <map>
+#include <vector>
+
+#include "base/command_line.h"

[erikwright (departed), 2014/06/11 13:27:48]

forward decl?

[Sigurður Ásgeirsson, 2014/06/11 13:55:27]

Done.

+#include "base/synchronization/lock.h"
+#include "breakpad/src/client/windows/handler/exception_handler.h"
+
+namespace breakpad {
+
+class BreakpadClient;
+
+// Manages the breakpad key/value pair stash, there may only be one instance
+// of this class per process at one time.
+class CrashKeysWin {
+ public:
+  CrashKeysWin();
+  ~CrashKeysWin();
+
+  // May only be called once.
+  // |exe_path| is the path to the executable running, which may be used
+  // to figure out whether this is a user or system install.
+  // |type| is the process type, or mode this process is running in e.g.
+  // something like "browser" or "renderer".
+  // |profile_type| is a string describing the kind of the user's Windows
+  // profile, e.g. "mandatory", or "roaming" or similar.
+  // |cmd_line| is the current process' command line consulted for explicit
+  // crash reporting flags.
+  // |breakpad_client| is consulted for crash reporting settings.
+  google_breakpad::CustomClientInfo* GetCustomInfo(

[erikwright (departed), 2014/06/11 13:27:48]

forward-decl or IWYU?

[Sigurður Ásgeirsson, 2014/06/11 13:55:27]

Done.

+        const std::wstring& exe_path,

[erikwright (departed), 2014/06/11 13:27:47]

IWYU

[Sigurður Ásgeirsson, 2014/06/11 13:55:26]

Done.

+        const std::wstring& type,
+        const std::wstring& profile_type,
+        CommandLine* cmd_line,
+        BreakpadClient* breakpad_client);
+
+  void SetCrashKeyValue(const std::wstring& key, const std::wstring& value);
+  void ClearCrashKeyValue(const std::wstring& key);
+
+  static CrashKeysWin* keeper() { return keeper_; }
+
+ private:
+  // One-time initialization of private key/value pairs.
+  void SetPluginPath(const std::wstring& path);
+  void SetBreakpadDumpPath(BreakpadClient* breakpad_client);
+
+  // Must not be resized after GetCustomInfo is invoked.
+  std::vector<google_breakpad::CustomInfoEntry> custom_entries_;

[erikwright (departed), 2014/06/11 13:27:47]

IWYU?

[Sigurður Ásgeirsson, 2014/06/11 13:55:27]

Done.

+
+  typedef std::map<std::wstring, google_breakpad::CustomInfoEntry*>
+      DynamicEntriesMap;
+  base::Lock lock_;
+  // Keeps track of the next index for a new dynamic entry.
+  size_t dynamic_keys_offset_;  // Under lock_.
+  // Maintains key->entry information for dynamic key/value entries
+  // in custom_entries_.
+  DynamicEntriesMap dynamic_entries_;  // Under lock_.
+
+  // Stores the sole instance of this class allowed per process.
+  static CrashKeysWin* keeper_;
+};

[erikwright (departed), 2014/06/11 13:27:48]

DISALLOW_COPY_AND_ASSIGN?

[Sigurður Ásgeirsson, 2014/06/11 13:55:27]

Done.

+
+}  // namespace breakpad