Change google_util::GetGoogleLocale() to take in the application locale

Change google_util::GetGoogleLocale() to take in the application locale

This function will be componentized and so cannot reference g_browser_process.
google_util::AppendGoogleLocaleToURL() will be handled in followup work.

BUG=373203
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276406

[Peter Kasting, 2014-06-10 19:01:32]

LGTM

https://codereview.chromium.org/327833002/diff/1/chrome/browser/google/google...
File chrome/browser/google/google_util.cc (right):

https://codereview.chromium.org/327833002/diff/1/chrome/browser/google/google...
chrome/browser/google/google_util.cc:75: return application_locale;
Nit: Even simpler:

  // Google does not recognize "nb" for Norwegian Bokmal; it uses "no".
  return (application_locale == "nb") ? "no" : application_locale;

[blundell, 2014-06-10 20:00:51]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-10 20:04:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/327833002/20001

[commit-bot: I haz the power, 2014-06-11 05:01:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 05:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 05:16:15]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[blundell, 2014-06-11 11:12:13]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-11 11:14:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/327833002/20001

[blundell, 2014-06-11 11:39:56]

https://codereview.chromium.org/327833002/diff/1/chrome/browser/google/google...
File chrome/browser/google/google_util.cc (right):

https://codereview.chromium.org/327833002/diff/1/chrome/browser/google/google...
chrome/browser/google/google_util.cc:75: return application_locale;
On 2014/06/10 19:01:31, Peter Kasting wrote:
> Nit: Even simpler:
> 
>   // Google does not recognize "nb" for Norwegian Bokmal; it uses "no".
>   return (application_locale == "nb") ? "no" : application_locale;

Done.

[commit-bot: I haz the power, 2014-06-11 15:24:58]

Change committed as 276406