Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 327823004: Adding milliseconds to test timestamps. (Closed)

Created:
6 years, 6 months ago by Victor Starodub
Modified:
6 years, 6 months ago
Reviewers:
bulach, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adding milliseconds to test timestamps. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276322

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed format to 8.3f to better match original. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/utils/run_tests_helper.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Victor Starodub
This way we'll get some helpful timing info for every test run "for free".
6 years, 6 months ago (2014-06-10 15:53:09 UTC) #1
bulach
lgtm, but please wait for john, thanks!
6 years, 6 months ago (2014-06-10 16:12:22 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/327823004/diff/1/build/android/pylib/utils/run_tests_helper.py File build/android/pylib/utils/run_tests_helper.py (right): https://codereview.chromium.org/327823004/diff/1/build/android/pylib/utils/run_tests_helper.py#newcode30 build/android/pylib/utils/run_tests_helper.py:30: return '%s %7.3fs %s' % (record.levelname[0], ...
6 years, 6 months ago (2014-06-10 16:32:17 UTC) #3
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 6 months ago (2014-06-10 23:09:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/327823004/20001
6 years, 6 months ago (2014-06-10 23:12:19 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 09:38:02 UTC) #6
Message was sent while issue was closed. 
Change committed as 276322

Powered by Google App Engine
This is Rietveld 408576698