Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 327823002: Remove MakeSqliteAppCacheDbTest (Closed)

Created:
6 years, 6 months ago by pilgrim_google
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove MakeSqliteAppCacheDbTest jam says this is obsolete/unused Also breaks chrome->appcache_interfaces.h dependency BUG=338338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276389

Patch Set 1 #

Patch Set 2 : fix kDiagnosticsTestCount #

Patch Set 3 : bad upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M chrome/browser/diagnostics/diagnostics_model.cc View 1 2 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.h View 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 2 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pilgrim_google
6 years, 6 months ago (2014-06-10 15:22:50 UTC) #1
jam
just to clarify: I had meant that this was added a long time ago, and ...
6 years, 6 months ago (2014-06-10 16:25:56 UTC) #2
cpu_(ooo_6.6-7.5)
diagnostics mode is really gspencer deal, he has been improving it for chrome os.
6 years, 6 months ago (2014-06-10 18:24:53 UTC) #3
Greg Spencer (Chromium)
On 2014/06/10 18:24:53, cpu wrote: > diagnostics mode is really gspencer deal, he has been ...
6 years, 6 months ago (2014-06-10 23:07:50 UTC) #4
Greg Spencer (Chromium)
LGTM from my point of view, but someone else must also approve.
6 years, 6 months ago (2014-06-10 23:16:30 UTC) #5
jabdelmalek
lgtm
6 years, 6 months ago (2014-06-10 23:19:37 UTC) #6
jam
lgtm
6 years, 6 months ago (2014-06-10 23:19:51 UTC) #7
cpu_(ooo_6.6-7.5)
lgtm
6 years, 6 months ago (2014-06-10 23:48:07 UTC) #8
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 6 months ago (2014-06-11 04:16:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/327823002/40001
6 years, 6 months ago (2014-06-11 04:19:21 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 14:30:14 UTC) #11
Message was sent while issue was closed.
Change committed as 276389

Powered by Google App Engine
This is Rietveld 408576698