Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 327803006: Added common git 'fetch' function (Closed)

Created:
6 years, 6 months ago by dnj
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Added common git 'fetch' function Replaced multiple various invocations of 'git fetch' with calls to a common fetch function. BUG=373504 TEST=localtest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=279560

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed underscore heh~ #

Total comments: 2

Patch Set 3 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M gclient_scm.py View 1 2 5 chunks +27 lines, -13 lines 0 comments Download
M tests/gclient_scm_test.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dnj
PTAL Depends on: https://codereview.chromium.org/326153003/
6 years, 6 months ago (2014-06-10 20:51:34 UTC) #1
dnj
ping (+mmoss, +nodir)
6 years, 6 months ago (2014-06-16 15:38:21 UTC) #2
dnj
+maruel, since he knows 'gclient'.
6 years, 6 months ago (2014-06-16 18:33:28 UTC) #3
dnj
PING (maruel@, I'd like you to be primary reviewer since the others don't have time ...
6 years, 6 months ago (2014-06-23 20:38:51 UTC) #4
M-A Ruel
https://codereview.chromium.org/327803006/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/327803006/diff/1/gclient_scm.py#newcode1040 gclient_scm.py:1040: def _Run(self, args, options, _show_header=True, **kwargs): Why an underscore ...
6 years, 6 months ago (2014-06-24 21:11:52 UTC) #5
dnj
https://codereview.chromium.org/327803006/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/327803006/diff/1/gclient_scm.py#newcode1040 gclient_scm.py:1040: def _Run(self, args, options, _show_header=True, **kwargs): On 2014/06/24 21:11:52, ...
6 years, 6 months ago (2014-06-24 21:45:23 UTC) #6
M-A Ruel
lgtm https://codereview.chromium.org/327803006/diff/20001/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/327803006/diff/20001/gclient_scm.py#newcode1039 gclient_scm.py:1039: if remote is None: remote = remote or ...
6 years, 6 months ago (2014-06-25 00:29:31 UTC) #7
dnj
Thanks for reviewing this! https://codereview.chromium.org/327803006/diff/20001/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/327803006/diff/20001/gclient_scm.py#newcode1039 gclient_scm.py:1039: if remote is None: On ...
6 years, 6 months ago (2014-06-25 00:36:56 UTC) #8
dnj
The CQ bit was checked by dnj@chromium.org
6 years, 6 months ago (2014-06-25 00:37:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnj@chromium.org/327803006/40001
6 years, 6 months ago (2014-06-25 00:37:50 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 00:39:35 UTC) #11
Message was sent while issue was closed.
Change committed as 279560

Powered by Google App Engine
This is Rietveld 408576698