Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2925)

Unified Diff: build/common.gypi

Issue 327803005: Update the default GYP flags for sanitizer tools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 73c2a4461b33f77cf44c58132bf493612feb57a7..abc3253a50ed7dd314822c4f93855b9c81e4dda4 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2030,7 +2030,7 @@
],
}],
- ['asan==1', {
+ ['asan==1 or msan==1 or lsan==1 or tsan==1', {
'clang%': 1,
'use_allocator%': 'none',
}],
@@ -2042,15 +2042,14 @@
# runtime is fully adopted. See http://crbug.com/242503.
'mac_strip_release': 0,
}],
- ['lsan==1', {
- 'clang%': 1,
- }],
['tsan==1', {
- 'clang%': 1,
'use_custom_libcxx%': 1,
}],
['msan==1', {
- 'clang%': 1,
+ 'use_custom_libcxx%': 1,
+ # Running the V8-generated code on an ARM simulator is a powerful hack
+ # that allows the tool to see the memory accesses from JITted code.
Alexander Potapenko 2014/06/16 10:40:43 Is this required to avoid false positives? If so,
+ 'v8_target_arch': 'arm64',
}],
['OS=="linux" and clang_type_profiler==1', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698