Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 327773004: Remove include of StyleResolverState.h from StyleResolver.h (Closed)

Created:
6 years, 6 months ago by davve
Modified:
6 years, 6 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, rwlbuis, darktears, gavinp+prerender_chromium.org, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove include of StyleResolverState.h from StyleResolver.h Instead add includes to .cpp files that needs things that StyleResolverState.h included for them. This brings down the amount of recompilation drastically (from ~720 to ~20) when touching files like FontBuilder.h or StyleResolverState.h. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176195

Patch Set 1 #

Patch Set 2 : Rebased for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M Source/core/animation/EffectInput.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
davve
Alan, could you review this? I've been touching FontBuilder.h a bit lately and got a ...
6 years, 6 months ago (2014-06-10 20:40:37 UTC) #1
alancutter (OOO until 2018)
Sorry for the delay, lgtm! Happy to see include scope reduced. :)
6 years, 6 months ago (2014-06-15 13:42:29 UTC) #2
davve
The CQ bit was checked by davve@opera.com
6 years, 6 months ago (2014-06-16 07:21:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/327773004/1
6 years, 6 months ago (2014-06-16 07:22:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 07:22:26 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/css/FontFaceSet.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-16 07:22:27 UTC) #6
davve
The CQ bit was checked by davve@opera.com
6 years, 6 months ago (2014-06-16 07:47:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/327773004/20001
6 years, 6 months ago (2014-06-16 07:48:10 UTC) #8
davve
6 years, 6 months ago (2014-06-16 08:29:20 UTC) #9
philipj_slow
lgtm
6 years, 6 months ago (2014-06-16 08:31:16 UTC) #10
davve
The CQ bit was unchecked by davve@opera.com
6 years, 6 months ago (2014-06-16 08:32:23 UTC) #11
davve
The CQ bit was checked by davve@opera.com
6 years, 6 months ago (2014-06-16 08:36:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/327773004/20001
6 years, 6 months ago (2014-06-16 08:37:00 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 09:16:17 UTC) #14
Message was sent while issue was closed.
Change committed as 176195

Powered by Google App Engine
This is Rietveld 408576698