Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 327703005: The position of opaque black rect is incorrect when alpha is false. (Closed)

Created:
6 years, 6 months ago by zino
Modified:
6 years, 6 months ago
Reviewers:
fs, Justin Novosad
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

The position of opaque black rect is incorrect when alpha is false. It should be drawn using the layout rect instead of the canvas size rect. BUG=382884 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176024

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : rebase #

Patch Set 4 : v/g/f/c/alpha.html needs rebaseline as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/alpha.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
zino
Please take a look. It was be already covered by fast/canvas/alpha.html. But the expected image ...
6 years, 6 months ago (2014-06-10 12:00:38 UTC) #1
fs
Fix LGTM. But maybe you could also add a test where the difference between the ...
6 years, 6 months ago (2014-06-10 12:29:59 UTC) #2
zino
On 2014/06/10 12:29:59, fs wrote: > Fix LGTM. But maybe you could also add a ...
6 years, 6 months ago (2014-06-10 16:19:45 UTC) #3
zino
On 2014/06/10 16:19:45, zino wrote: > On 2014/06/10 12:29:59, fs wrote: > > Fix LGTM. ...
6 years, 6 months ago (2014-06-12 07:52:33 UTC) #4
fs
On 2014/06/12 07:52:33, zino wrote: > On 2014/06/10 16:19:45, zino wrote: > > On 2014/06/10 ...
6 years, 6 months ago (2014-06-12 08:26:03 UTC) #5
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 6 months ago (2014-06-12 08:30:13 UTC) #6
zino
The CQ bit was unchecked by jinho.bang@samsung.com
6 years, 6 months ago (2014-06-12 08:30:15 UTC) #7
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 6 months ago (2014-06-12 08:58:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/327703005/60001
6 years, 6 months ago (2014-06-12 08:59:52 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-12 10:11:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 10:38:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/11721)
6 years, 6 months ago (2014-06-12 10:38:28 UTC) #12
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 6 months ago (2014-06-12 11:04:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/327703005/80001
6 years, 6 months ago (2014-06-12 11:07:38 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-12 12:15:41 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 13:23:38 UTC) #16
Message was sent while issue was closed.
Change committed as 176024

Powered by Google App Engine
This is Rietveld 408576698