Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 327703004: Revert "Port 'external startup data' flag from gyp to gn." (Closed)

Created:
6 years, 6 months ago by Michael Starzinger
Modified:
6 years, 6 months ago
Reviewers:
vogelheim
CC:
v8-dev
Visibility:
Public.

Description

Revert "Port 'external startup data' flag from gyp to gn." This cause compile failures on the GN buildbot about 'gen/v8/libraries.bin' missing and no known rule to make it. TBR=vogelheim@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -92 lines) Patch
M BUILD.gn View 6 chunks +12 lines, -92 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
6 years, 6 months ago (2014-06-10 10:05:45 UTC) #1
Michael Starzinger
6 years, 6 months ago (2014-06-10 10:06:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r21739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698