Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 327633003: Fix rebaseline-o-matic logging. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Visibility:
Public.

Description

Fix rebaseline-o-matic logging. We'd miss any output between the last poll and the end of the process. Also, print out the log lines so that you can see them when looking at the local log. BUG=382248 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -14 lines) Patch
M Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 2 chunks +21 lines, -9 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +20 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ojan
6 years, 6 months ago (2014-06-10 00:11:48 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-10 00:37:14 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-10 00:38:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/327633003/1
6 years, 6 months ago (2014-06-10 00:38:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-10 01:42:15 UTC) #5
ojan
The CQ bit was unchecked by ojan@chromium.org
6 years, 6 months ago (2014-06-10 02:17:05 UTC) #6
ojan
There are some issues here, but I'll fix them in a followup patch.
6 years, 6 months ago (2014-06-13 21:57:03 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 21:58:30 UTC) #8
Message was sent while issue was closed.
Change committed as 176135

Powered by Google App Engine
This is Rietveld 408576698