Introduce WebFallbackFont on the Chromium side

Introduce WebFallbackFont on the Chromium side

Patch 2 in the series of renaming WebFontFamily to WebFallbackFont,
at the same time, fixing the sandbox support IPC to transmit filename
and ttcIndex. Depends on step 1 of the rename, r175858 in Blink.

BUG=382411
R=eae,behdad,jln,piman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276520

[piman, 2014-06-10 01:30:09]

lgtm

https://codereview.chromium.org/327633002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/sandbox_ipc_linux.cc (right):

https://codereview.chromium.org/327633002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/sandbox_ipc_linux.cc:343: else {
nit: } else {

[jln (very slow on Chromium), 2014-06-10 01:52:34]

lgtm, but please be careful on the Blink side.

https://codereview.chromium.org/327633002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/sandbox_ipc_linux.cc (right):

https://codereview.chromium.org/327633002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/sandbox_ipc_linux.cc:332:
WebFontInfo::fallbackFontForChar(c, preferred_locale.c_str(), &fallbackFont);
Is it clear on the Blink side of this that this is running unsandboxed and with
untrusted input?

Also I just updated my tree and I don't have fallbackFontForChar in Blink. I
presume it's not rolled in DEPS yet?

https://codereview.chromium.org/327633002/diff/1/content/common/child_process...
File content/common/child_process_sandbox_support_impl_linux.h (right):

https://codereview.chromium.org/327633002/diff/1/content/common/child_process...
content/common/child_process_sandbox_support_impl_linux.h:27: const char*
preferred_locale,
Nit: indent

[Dominik Röttsches, 2014-06-10 07:44:52]

piman, jln - thanks for your quick reviews!

https://codereview.chromium.org/327633002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/sandbox_ipc_linux.cc (right):

https://codereview.chromium.org/327633002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/sandbox_ipc_linux.cc:332:
WebFontInfo::fallbackFontForChar(c, preferred_locale.c_str(), &fallbackFont);
On 2014/06/10 01:52:34, jln wrote:
> Is it clear on the Blink side of this that this is running unsandboxed and
with
> untrusted input?

Yes - that is clear and unfortunately required when talking to Fontconfig.

> Also I just updated my tree and I don't have fallbackFontForChar in Blink. I
> presume it's not rolled in DEPS yet?

Correct, it should arrive with a roll past r175858.

[Dominik Röttsches, 2014-06-10 11:09:50]

The CQ bit was checked by dominik.rottsches@intel.com

[commit-bot: I haz the power, 2014-06-10 11:11:09]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/327633002/...

[Dominik Röttsches, 2014-06-10 13:20:23]

piman, jln - okay with you if I override the presubmit script here by manually
committing, since it's just a rename and I am not really adding the file? Also,
I think, the sandbox_support is an exception to the presubmit checks.

[jln (very slow on Chromium), 2014-06-10 21:31:30]

On 2014/06/10 13:20:23, Dominik Röttsches wrote:
> piman, jln - okay with you if I override the presubmit script here by manually
> committing, since it's just a rename and I am not really adding the file?
Also,
> I think, the sandbox_support is an exception to the presubmit checks.

Please edit content/common/DEPS instead and rename WebFontFamily.h there.

[commit-bot: I haz the power, 2014-06-11 07:18:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 07:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 07:24:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Dominik Röttsches, 2014-06-11 08:04:34]

On 2014/06/10 21:31:30, jln wrote:
> Please edit content/common/DEPS instead and rename WebFontFamily.h there.

Thanks for the hint! Sorry I missed that.

[Dominik Röttsches, 2014-06-11 08:04:39]

The CQ bit was checked by dominik.rottsches@intel.com

[commit-bot: I haz the power, 2014-06-11 08:05:16]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/327633002/...

[Dominik Röttsches, 2014-06-11 12:14:26]

If I understand the presubmit message correctly here, Adam, could you LGTM this
for public/ as well?

> ** Presubmit ERRORS **
> Missing LGTM from OWNERS of dependencies added to DEPS:
>    '+third_party/WebKit/public/platform/linux/WebFallbackFont.h',

[commit-bot: I haz the power, 2014-06-11 14:07:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-06-11 14:10:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 14:10:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[abarth-chromium, 2014-06-11 20:43:05]

https://codereview.chromium.org/327633002/diff/40001/content/common/DEPS
File content/common/DEPS (right):

https://codereview.chromium.org/327633002/diff/40001/content/common/DEPS#newc...
content/common/DEPS:35:
"+third_party/WebKit/public/platform/linux/WebFallbackFont.h",
LGTM

WebFallbackFont.h is just a struct + CString and so won't pull all of Blink into
the browser DLL.

[Dominik Röttsches, 2014-06-11 20:47:50]

The CQ bit was checked by dominik.rottsches@intel.com

[commit-bot: I haz the power, 2014-06-11 20:53:05]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/327633002/...

[commit-bot: I haz the power, 2014-06-12 03:42:45]

Change committed as 276520