Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tools/telemetry/telemetry/page/page_measurement_results.py

Issue 327583002: Move results related stuff to telemetry/results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change the directory name from test_results to results Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_measurement_results.py
diff --git a/tools/telemetry/telemetry/page/page_measurement_results.py b/tools/telemetry/telemetry/page/page_measurement_results.py
deleted file mode 100644
index ee22b2fc69701de127daea53bb36d516c4ed92be..0000000000000000000000000000000000000000
--- a/tools/telemetry/telemetry/page/page_measurement_results.py
+++ /dev/null
@@ -1,101 +0,0 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from telemetry import value as value_module
-from telemetry.page import page_test_results
-from telemetry.value import value_backcompat
-
-class PageMeasurementResults(page_test_results.PageTestResults):
- def __init__(self, output_stream=None, trace_tag=''):
- super(PageMeasurementResults, self).__init__(output_stream)
- self._done = False
- self._trace_tag = trace_tag
-
- self._current_page = None
- self._page_specific_values_for_current_page = None
-
- self._representative_values_for_each_value_name = {}
-
- self._all_summary_values = []
- self._all_page_specific_values = []
-
- @property
- def pages_that_succeeded(self):
- pages = set([value.page for value in self._all_page_specific_values])
- pages.difference_update(self.pages_that_had_errors_or_failures)
- return pages
-
- @property
- def current_page(self):
- return self._current_page
-
- @property
- def all_value_names_that_have_been_seen(self):
- return list(self._representative_values_for_each_value_name.keys())
-
- def GetUnitsForValueName(self, value_name):
- return self._representative_values_for_each_value_name[value_name].units
-
- @property
- def all_page_specific_values(self):
- return self._all_page_specific_values
-
- @property
- def page_specific_values_for_current_page(self):
- assert self._current_page
- return self._page_specific_values_for_current_page
-
- def WillMeasurePage(self, page):
- assert not self._current_page
- self._current_page = page
- self._page_specific_values_for_current_page = []
-
- def Add(self, trace_name, units, value, chart_name=None, data_type='default'):
- # TODO(isherman): Remove this as well.
- value = value_backcompat.ConvertOldCallingConventionToValue(
- self._current_page,
- trace_name, units, value, chart_name, data_type)
- self.AddValue(value)
-
- def AddValue(self, value):
- self._ValidateValue(value)
- self._page_specific_values_for_current_page.append(value)
- self._all_page_specific_values.append(value)
-
- def AddSummaryValue(self, value):
- assert value.page is None
- self._ValidateValue(value)
- self._all_summary_values.append(value)
-
- def _ValidateValue(self, value):
- assert isinstance(value, value_module.Value)
-
- if value.name not in self._representative_values_for_each_value_name:
- self._representative_values_for_each_value_name[value.name] = value
-
- representative_value = self._representative_values_for_each_value_name[
- value.name]
-
- assert value.IsMergableWith(representative_value)
-
- def DidMeasurePage(self):
- assert self._current_page, 'Failed to call WillMeasurePage'
- self._current_page = None
- self._page_specific_values_for_current_page = None
-
-
- def FindPageSpecificValuesForPage(self, page, value_name):
- values = []
- for value in self._all_page_specific_values:
- if value.page == page and value.name == value_name:
- values.append(value)
- return values
-
-
- def FindAllPageSpecificValuesNamed(self, value_name):
- values = []
- for value in self._all_page_specific_values:
- if value.name == value_name:
- values.append(value)
- return values

Powered by Google App Engine
This is Rietveld 408576698