Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 327573003: Reboot device after configuring in provision script. (Closed)

Created:
6 years, 6 months ago by navabi
Modified:
6 years, 6 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Reboot device after configuring in provision script. BUG=379219 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276162

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed nit. #

Patch Set 3 : Added TODO for jbudorick. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/android/provision_devices.py View 1 2 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
navabi
6 years, 6 months ago (2014-06-09 20:47:35 UTC) #1
navabi
This adds 30 extra seconds with local testing of one device attached. Because the devices ...
6 years, 6 months ago (2014-06-09 20:54:22 UTC) #2
tonyg
lgtm Thanks for taking care of this. https://codereview.chromium.org/327573003/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/327573003/diff/1/build/android/provision_devices.py#newcode151 build/android/provision_devices.py:151: .old_interface.Reboot(True)) Nit: ...
6 years, 6 months ago (2014-06-09 20:56:29 UTC) #3
jbudorick
lgtm https://codereview.chromium.org/327573003/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/327573003/diff/1/build/android/provision_devices.py#newcode149 build/android/provision_devices.py:149: try: Can you add a TODO for me ...
6 years, 6 months ago (2014-06-09 20:57:16 UTC) #4
navabi
https://codereview.chromium.org/327573003/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/327573003/diff/1/build/android/provision_devices.py#newcode149 build/android/provision_devices.py:149: try: On 2014/06/09 20:57:15, jbudorick wrote: > Can you ...
6 years, 6 months ago (2014-06-09 22:56:19 UTC) #5
navabi
The CQ bit was checked by navabi@google.com
6 years, 6 months ago (2014-06-09 22:57:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/327573003/40001
6 years, 6 months ago (2014-06-09 22:58:49 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-10 05:02:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 14:45:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/25280)
6 years, 6 months ago (2014-06-10 14:45:46 UTC) #10
navabi
The CQ bit was checked by navabi@google.com
6 years, 6 months ago (2014-06-10 19:21:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/327573003/40001
6 years, 6 months ago (2014-06-10 19:26:09 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 21:35:58 UTC) #13
Message was sent while issue was closed.
Change committed as 276162

Powered by Google App Engine
This is Rietveld 408576698