LayoutTests/media/video-preload-none-no-stalled-event.html - Issue 327553002: Transition networkState back to NETWORK_IDLE on fetch if preload=none

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-preload-none-no-stalled-event.html

Issue 327553002: Transition networkState back to NETWORK_IDLE on fetch if preload=none (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src=media-file.js></script>

	3 <script src=video-test.js></script>

	4 <script>

	5 function runTest()

	6 {

	7 findMediaElement();

	8

	9 waitForEvent("suspend");

	10 waitForEventAndFail("stalled");

	11 consoleWrite("");

	12

	13 video.src = findMediaFile("video", "content/test");

	14

	15 // Give the progress timer enoug time to fire a 'stalled' event.
	acolwell GONE FROM CHROMIUM 2014/06/09 17:54:17 nit: s/enoug/enough/ nit: s/enoug/enough/
	16 // (3s timeout + 0.5s slack)

	17 setTimeout(endTest, 3000 + 500);
	acolwell GONE FROM CHROMIUM 2014/06/09 17:54:17 This seems brittle. How about using waitForEventAn This seems brittle. How about using waitForEventAndEnd("suspend") instead and let the normal timeout cause the test to fail? fs 2014/06/10 12:36:24 SGTM. Done. Show quoted text On 2014/06/09 17:54:17, acolwell wrote: > This seems brittle. How about using waitForEventAndEnd("suspend") instead and > let the normal timeout cause the test to fail? SGTM. Done.
	18 }

	19 </script>

	20 <body onload="runTest()">

	21 <p>Test to see if a media element with preload=none dispatches a 'stalled' eve nt.</p>

	22 <video preload=none></video>

	23 </body>

OLD	NEW