mojo/public/cpp/application/lib/service_connector.h - Issue 327523004: Introduce very beginning of navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/application/lib/service_connector.h

Issue 327523004: Introduce very beginning of navigation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use a temporary connection per navigation Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/application/lib/service_connector.h

diff --git a/mojo/public/cpp/application/lib/service_connector.h b/mojo/public/cpp/application/lib/service_connector.h

index 914b2a924e85614cb08c9eacf93f269c889a1b14..b52140b03b82e9d7c0e628ffe2fb14feb6de8024 100644

--- a/mojo/public/cpp/application/lib/service_connector.h

+++ b/mojo/public/cpp/application/lib/service_connector.h

@@ -123,8 +123,6 @@ class ServiceConnector : public internal::ServiceConnectorBase {

if (*it == impl) {

delete impl;

connections_.erase(it);

- if (connections_.empty())

- owner_->RemoveServiceConnector(this);

Aaron Boodman 2014/06/10 19:41:29 I believe this is incorrect. Just because last con

return;

}