mojo/services/navigation/navigation.mojom - Issue 327523004: Introduce very beginning of navigation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/navigation/navigation.mojom

Issue 327523004: Introduce very beginning of navigation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mojo.navigation {

	6

	7 struct NavigationDetails {

	8 string url;

	9 // TODO(aa): method, data, etc.

	10 };

	11

	12 // Applications implement this interface to support navigation of their views
	sky 2014/06/10 22:15:14 Your use of view here and below is confusing (and Your use of view here and below is confusing (and I think wrong). AFAICT you're navigating the node. See EmbeddedAPp, where view_id is the id of the node. At a minimum rename view_id (and update your description too). But you should also consider renaming this to just Navigator. Aaron Boodman 2014/06/10 22:31:31 Ah, you are right, I started with view_id, but cha Show quoted text On 2014/06/10 22:15:14, sky wrote: > Your use of view here and below is confusing (and I think wrong). AFAICT you're > navigating the node. See EmbeddedAPp, where view_id is the id of the node. At a > minimum rename view_id (and update your description too). But you should also > consider renaming this to just Navigator. Ah, you are right, I started with view_id, but changed to node_id and forgot to change here. The interface name was intentional, but I see why you think it is confusing. There is eventually going to be another interface, implemented by the embedder. I was going to name this NodeNavigator (to parallel the Node/View relationship). Anyway, I changed it to just Navigator for now.
	13 // by embedders.

	14 interface ViewNavigator {

	15 Navigate(uint32 view_id, NavigationDetails details);

	16 };

	17

	18 }

OLD	NEW

« mojo/public/cpp/application/lib/service_connector.h ('K') | « mojo/public/cpp/application/lib/service_connector.h ('k') | mojo/shell/mojo_url_resolver.cc » ('j') | no next file with comments »