Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 327523003: Move all MetricsLog unittests into components_unittests (Closed)

Created:
6 years, 6 months ago by blundell
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org, jar+watch_chromium.org
Visibility:
Public.

Description

Move all MetricsLog unittests into components_unittests This CL merges the unittest suites in //chrome/browser/metrics/metrics_log_unittest and //components/metrics/metrics_log_unittest, putting all of the unittests into the latter and eliminating the former. BUG=382549 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276468

Patch Set 1 #

Total comments: 6

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -301 lines) Patch
D chrome/browser/metrics/metrics_log_unittest.cc View 1 chunk +0 lines, -289 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/metrics_log_unittest.cc View 1 5 chunks +259 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
blundell
6 years, 6 months ago (2014-06-09 18:25:14 UTC) #1
Alexei Svitkine (slow)
LGTM % comments https://codereview.chromium.org/327523003/diff/1/components/metrics/metrics_log_unittest.cc File components/metrics/metrics_log_unittest.cc (right): https://codereview.chromium.org/327523003/diff/1/components/metrics/metrics_log_unittest.cc#newcode11 components/metrics/metrics_log_unittest.cc:11: #include "base/command_line.h" Is this include needed? ...
6 years, 6 months ago (2014-06-11 00:59:19 UTC) #2
blundell
TBR=thakis for chrome_tests.gypi https://codereview.chromium.org/327523003/diff/1/components/metrics/metrics_log_unittest.cc File components/metrics/metrics_log_unittest.cc (right): https://codereview.chromium.org/327523003/diff/1/components/metrics/metrics_log_unittest.cc#newcode11 components/metrics/metrics_log_unittest.cc:11: #include "base/command_line.h" On 2014/06/11 00:59:19, Alexei ...
6 years, 6 months ago (2014-06-11 09:36:30 UTC) #3
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 6 months ago (2014-06-11 09:36:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/327523003/20001
6 years, 6 months ago (2014-06-11 09:38:20 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 18:58:35 UTC) #6
Message was sent while issue was closed.
Change committed as 276468

Powered by Google App Engine
This is Rietveld 408576698