Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 327523002: Change skia build files to use a utils.gypi instead of hardcoded files. (Closed)

Created:
6 years, 6 months ago by egdaniel
Modified:
6 years, 6 months ago
Reviewers:
bungeman-skia, bsalomon
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change skia build files to use a utils.gypi instead of hardcoded files. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276188

Patch Set 1 : #

Patch Set 2 : Add excluded files to skia_library #

Total comments: 1

Patch Set 3 : Add gn excludes #

Patch Set 4 : Fix gn path format on excludes #

Patch Set 5 : use double quote for gn #

Patch Set 6 : Fix conflicts with the auto gn filter #

Patch Set 7 : Delete extra win lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -74 lines) Patch
M skia/BUILD.gn View 1 2 3 4 5 6 3 chunks +94 lines, -0 lines 0 comments Download
M skia/skia_gn_files.gypi View 2 chunks +0 lines, -41 lines 0 comments Download
M skia/skia_library.gypi View 1 3 chunks +79 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
egdaniel
So in this current version I've changed chromes gyp (and gn) to read in skia's ...
6 years, 6 months ago (2014-06-09 14:46:41 UTC) #1
bungeman-skia
https://codereview.chromium.org/327523002/diff/60001/skia/skia_library.gypi File skia/skia_library.gypi (right): https://codereview.chromium.org/327523002/diff/60001/skia/skia_library.gypi#newcode92 skia/skia_library.gypi:92: # Exclude all unused files in skia utils.gypi file ...
6 years, 6 months ago (2014-06-09 15:39:03 UTC) #2
egdaniel
yes the gn file needed them
6 years, 6 months ago (2014-06-09 15:51:51 UTC) #3
bungeman-skia
So long as everything still builds, lgtm.
6 years, 6 months ago (2014-06-09 16:00:57 UTC) #4
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 6 months ago (2014-06-10 15:01:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egdaniel@google.com/327523002/150001
6 years, 6 months ago (2014-06-10 15:03:32 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 22:52:12 UTC) #7
Message was sent while issue was closed.
Change committed as 276188

Powered by Google App Engine
This is Rietveld 408576698