Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 327503003: Added 250p scale factor. (Closed)

Created:
6 years, 6 months ago by Mateusz Szymański
Modified:
6 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Recent update to Windows 8.1 added new default High DPI mode - 250% for qHD displays. This is initial work package to reflect this change, making it possible to add hi-resolution resources in the future (if needed). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ui/base/layout.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/layout.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/layout_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Mateusz Szymański
6 years, 6 months ago (2014-06-09 13:47:05 UTC) #1
Mateusz Szymański
6 years, 6 months ago (2014-06-09 13:47:17 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm please flesh out the CL description. Like why do this, what is the motivation ...
6 years, 6 months ago (2014-06-10 01:28:29 UTC) #3
Mateusz Szymański
The CQ bit was checked by mateuszs@opera.com
6 years, 6 months ago (2014-06-10 08:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mateuszs@opera.com/327503003/1
6 years, 6 months ago (2014-06-10 08:17:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 19:35:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 19:38:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/72761)
6 years, 6 months ago (2014-06-10 19:38:45 UTC) #8
Mateusz Szymański
Can I have LGTM once more please?
6 years, 6 months ago (2014-06-11 07:34:01 UTC) #9
sky
LGTM
6 years, 6 months ago (2014-06-11 16:07:44 UTC) #10
Mateusz Szymański
The CQ bit was checked by mateuszs@opera.com
6 years, 6 months ago (2014-06-12 06:28:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mateuszs@opera.com/327503003/1
6 years, 6 months ago (2014-06-12 06:33:34 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 06:42:30 UTC) #13
Message was sent while issue was closed.
Change committed as 276551

Powered by Google App Engine
This is Rietveld 408576698