Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 327473002: Prepare SVGDocumentExtensions::m_elementDependencies for oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add comment about rebuild Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 7b84ce2671c2a15a0a07e0219a01a881266e0b29..9d24a7c4072f042dadac6f4ab7e4920dc934fbfc 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -100,9 +100,12 @@ SVGElement::~SVGElement()
m_SVGRareData.clear();
}
+ // FIXME: Oilpan: Some of the rebuild callbacks are still required in oilpan.
+ // We need to convert all of them to weak processing.
+ document().accessSVGExtensions().rebuildAllElementReferencesForTarget(this);
+
// With Oilpan, either removedFrom has been called or the document is dead
// as well and there is no reason to clear out the extensions.
- document().accessSVGExtensions().rebuildAllElementReferencesForTarget(this);
document().accessSVGExtensions().removeAllElementReferencesForTarget(this);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698