Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: Source/core/svg/SVGAnimateMotionElement.cpp

Issue 327463002: SVG: no need to call |clearAnimatedType| at SVGAnimate{,Motion}Element dtor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAnimateElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 , m_hasToPointAtEndOfDuration(false) 44 , m_hasToPointAtEndOfDuration(false)
45 { 45 {
46 setCalcMode(CalcModePaced); 46 setCalcMode(CalcModePaced);
47 ScriptWrappable::init(this); 47 ScriptWrappable::init(this);
48 } 48 }
49 49
50 DEFINE_NODE_FACTORY(SVGAnimateMotionElement) 50 DEFINE_NODE_FACTORY(SVGAnimateMotionElement)
51 51
52 SVGAnimateMotionElement::~SVGAnimateMotionElement() 52 SVGAnimateMotionElement::~SVGAnimateMotionElement()
53 { 53 {
54 // FIXME: Oilpan: We should not comment this out and this should be moved to |removeFrom| equivalent.
55 #if !ENABLE(OILPAN)
56 if (targetElement())
57 clearAnimatedType(targetElement());
58 #endif
59 } 54 }
60 55
61 bool SVGAnimateMotionElement::hasValidAttributeType() 56 bool SVGAnimateMotionElement::hasValidAttributeType()
62 { 57 {
63 SVGElement* targetElement = this->targetElement(); 58 SVGElement* targetElement = this->targetElement();
64 if (!targetElement) 59 if (!targetElement)
65 return false; 60 return false;
66 61
67 // We don't have a special attribute name to verify the animation type. Chec k the element name instead. 62 // We don't have a special attribute name to verify the animation type. Chec k the element name instead.
68 if (!targetElement->isSVGGraphicsElement()) 63 if (!targetElement->isSVGGraphicsElement())
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 333
339 void SVGAnimateMotionElement::updateAnimationMode() 334 void SVGAnimateMotionElement::updateAnimationMode()
340 { 335 {
341 if (!m_animationPath.isEmpty()) 336 if (!m_animationPath.isEmpty())
342 setAnimationMode(PathAnimation); 337 setAnimationMode(PathAnimation);
343 else 338 else
344 SVGAnimationElement::updateAnimationMode(); 339 SVGAnimationElement::updateAnimationMode();
345 } 340 }
346 341
347 } 342 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimateElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698