Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: Source/core/svg/SVGAnimateElement.cpp

Issue 327463002: SVG: no need to call |clearAnimatedType| at SVGAnimate{,Motion}Element dtor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 29 matching lines...) Expand all
40 ScriptWrappable::init(this); 40 ScriptWrappable::init(this);
41 } 41 }
42 42
43 PassRefPtrWillBeRawPtr<SVGAnimateElement> SVGAnimateElement::create(Document& do cument) 43 PassRefPtrWillBeRawPtr<SVGAnimateElement> SVGAnimateElement::create(Document& do cument)
44 { 44 {
45 return adoptRefWillBeRefCountedGarbageCollected(new SVGAnimateElement(SVGNam es::animateTag, document)); 45 return adoptRefWillBeRefCountedGarbageCollected(new SVGAnimateElement(SVGNam es::animateTag, document));
46 } 46 }
47 47
48 SVGAnimateElement::~SVGAnimateElement() 48 SVGAnimateElement::~SVGAnimateElement()
49 { 49 {
50 // FIXME: Oilpan: Below prevent stopAnimValAnimation being called on |target Element|. This should be moved to |removeFrom| equivalent.
51 #if !ENABLE(OILPAN)
52 if (targetElement())
53 clearAnimatedType(targetElement());
54 #endif
55 } 50 }
56 51
57 AnimatedPropertyType SVGAnimateElement::animatedPropertyType() 52 AnimatedPropertyType SVGAnimateElement::animatedPropertyType()
58 { 53 {
59 return ensureAnimator()->type(); 54 return ensureAnimator()->type();
60 } 55 }
61 56
62 bool SVGAnimateElement::hasValidAttributeType() 57 bool SVGAnimateElement::hasValidAttributeType()
63 { 58 {
64 SVGElement* targetElement = this->targetElement(); 59 SVGElement* targetElement = this->targetElement();
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 return m_animator.get(); 395 return m_animator.get();
401 } 396 }
402 397
403 void SVGAnimateElement::trace(Visitor* visitor) 398 void SVGAnimateElement::trace(Visitor* visitor)
404 { 399 {
405 visitor->trace(m_animator); 400 visitor->trace(m_animator);
406 SVGAnimationElement::trace(visitor); 401 SVGAnimationElement::trace(visitor);
407 } 402 }
408 403
409 } 404 }
OLDNEW
« no previous file with comments | « LayoutTests/svg/animations/animate-teardown-expected.txt ('k') | Source/core/svg/SVGAnimateMotionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698