Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 327423008: Change port to use apache by default on win7, update test expectations. (Closed)

Created:
6 years, 6 months ago by Dirk Pranke
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Change port to use apache by default on win7, update test expectations. This switches the default on Win 7 to use the native Win32 version of Apache 2.2 instead of LigHTTPd. In theory Apache will substantially more stable and also probably faster. I am hoping that this fixes the situation in bug 378444 where the server just doesn't work on some runs as well. We also match more of the test expectations on other platforms. If this change sticks and does improve flakiness, we'll try switching XP as well in a later change. This change also deletes all of the FlakyTest entries for http tests on Win7, so that we can better get a real sense of the flakiness. R=ojan@chromium.org BUG=378444, 30536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177046

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix test_http_server_supports_ipv6 #

Patch Set 3 : fix apache cgi registration, env issues #

Patch Set 4 : merge forward to r177025 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -449 lines) Patch
M LayoutTests/FlakyTests View 1 2 2 chunks +0 lines, -260 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
M LayoutTests/http/conf/win-httpd.conf View 1 chunk +7 lines, -11 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/misc/single-character-pi-stylesheet-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/navigation/post-301-response-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/navigation/post-302-response-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/navigation/post-303-response-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/cache-override-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/chunked-progress-event-expectedLength-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/methods-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/web-apps/012-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/web-apps/013-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/workers/methods-async-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress-response-type-blob-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/http/tests/misc/favicon-as-image-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/http/tests/misc/favicon-as-image-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
D LayoutTests/platform/win/http/tests/misc/single-character-pi-stylesheet-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/win/http/tests/navigation/post-301-response-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/win/http/tests/navigation/post-302-response-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/win/http/tests/navigation/post-303-response-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/win/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/cache-override-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/chunked-progress-event-expectedLength-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/methods-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/web-apps/012-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/web-apps/013-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/workers/methods-async-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress-response-type-blob-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/win/http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/win.py View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ojan
lgtm https://codereview.chromium.org/327423008/diff/1/LayoutTests/FlakyTests File LayoutTests/FlakyTests (left): https://codereview.chromium.org/327423008/diff/1/LayoutTests/FlakyTests#oldcode277 LayoutTests/FlakyTests:277: Bug(gardener) [ Release Win7 ] http/tests/appcache/modified-manifest.html [ Pass ...
6 years, 6 months ago (2014-06-14 22:47:21 UTC) #1
Dirk Pranke
On 2014/06/14 22:47:21, ojan wrote: > lgtm > > https://codereview.chromium.org/327423008/diff/1/LayoutTests/FlakyTests > File LayoutTests/FlakyTests (left): > ...
6 years, 6 months ago (2014-06-14 22:54:06 UTC) #2
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-14 22:54:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/327423008/1
6 years, 6 months ago (2014-06-14 22:55:01 UTC) #4
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-14 23:12:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/327423008/20001
6 years, 6 months ago (2014-06-14 23:13:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-15 00:55:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12007)
6 years, 6 months ago (2014-06-15 00:55:34 UTC) #8
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-27 00:22:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/327423008/60001
6 years, 6 months ago (2014-06-27 00:23:11 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-27 01:42:20 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 02:36:35 UTC) #12
Message was sent while issue was closed.
Change committed as 177046

Powered by Google App Engine
This is Rietveld 408576698