Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 327403003: Identity API: add chrome.identity.getProfileUserInfo (Closed)

Created:
6 years, 6 months ago by Michael Courage
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, jar+watch_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Identity API: add chrome.identity.getProfileUserInfo getProfileUserInfo returns the email address and obfuscated gaia id of the user signed into a profile. If the user is not signed in, empty strings are returned. This API is different from identity.getAccounts in two ways. The information returned is available offline, and it only applies to the primary account for the profile (even when multiple login is enabled). BUG=368343 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277724

Patch Set 1 #

Total comments: 2

Patch Set 2 : add documentation #

Patch Set 3 : rebase #

Patch Set 4 : add identity.email permission to stubs_app #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
M chrome/browser/extensions/api/identity/identity_api.h View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/identity.idl View 1 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/stubs_app/manifest.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Michael Courage
Depends on a new identity.email permission from https://codereview.chromium.org/328013002/.
6 years, 6 months ago (2014-06-12 19:02:51 UTC) #1
Michael Courage
+jar for histograms
6 years, 6 months ago (2014-06-12 19:03:54 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/327403003/diff/1/chrome/common/extensions/api/identity.idl File chrome/common/extensions/api/identity.idl (right): https://codereview.chromium.org/327403003/diff/1/chrome/common/extensions/api/identity.idl#newcode94 chrome/common/extensions/api/identity.idl:94: [nodoc] static void getProfileUserInfo(GetProfileUserInfoCallback callback); why nodoc?
6 years, 6 months ago (2014-06-12 21:17:20 UTC) #3
Michael Courage
On 2014/06/12 21:17:20, kalman wrote: > https://codereview.chromium.org/327403003/diff/1/chrome/common/extensions/api/identity.idl > File chrome/common/extensions/api/identity.idl (right): > > https://codereview.chromium.org/327403003/diff/1/chrome/common/extensions/api/identity.idl#newcode94 > ...
6 years, 6 months ago (2014-06-13 23:22:58 UTC) #4
Michael Courage
https://codereview.chromium.org/327403003/diff/1/chrome/common/extensions/api/identity.idl File chrome/common/extensions/api/identity.idl (right): https://codereview.chromium.org/327403003/diff/1/chrome/common/extensions/api/identity.idl#newcode94 chrome/common/extensions/api/identity.idl:94: [nodoc] static void getProfileUserInfo(GetProfileUserInfoCallback callback); On 2014/06/12 21:17:20, kalman ...
6 years, 6 months ago (2014-06-13 23:25:31 UTC) #5
not at google - send to devlin
idl lgtm, you should get somebody familiar with the impl to look at that
6 years, 6 months ago (2014-06-13 23:27:07 UTC) #6
Michael Courage
fgorski, can you check out chrome/browser/extensions/api/identity?
6 years, 6 months ago (2014-06-13 23:39:05 UTC) #7
fgorski
lgtm
6 years, 6 months ago (2014-06-16 17:44:52 UTC) #8
Michael Courage
The CQ bit was checked by courage@chromium.org
6 years, 6 months ago (2014-06-16 17:45:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/327403003/20001
6 years, 6 months ago (2014-06-16 17:46:39 UTC) #10
Michael Courage
The CQ bit was checked by courage@chromium.org
6 years, 6 months ago (2014-06-16 18:08:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/327403003/40001
6 years, 6 months ago (2014-06-16 18:10:19 UTC) #12
Michael Courage
+isherman for histograms
6 years, 6 months ago (2014-06-16 21:56:54 UTC) #13
Ilya Sherman
histograms.xml lgtm
6 years, 6 months ago (2014-06-16 21:59:36 UTC) #14
Michael Courage
The CQ bit was checked by courage@chromium.org
6 years, 6 months ago (2014-06-16 22:03:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/327403003/60001
6 years, 6 months ago (2014-06-16 22:04:51 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 11:21:55 UTC) #17
Message was sent while issue was closed. 
Change committed as 277724

Powered by Google App Engine
This is Rietveld 408576698