Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin().

tools/picture_utils.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "picture_utils.h"
 #include "SkBitmap.h"
 #include "SkColorPriv.h"
@@ skipping 23 matching lines @@
         if (NULL == str) {
             return;
         }
         for (size_t i = 0; i < str->size(); ++i) {
             if (oldChar == str->operator[](i)) {
                 str->operator[](i) = newChar;
             }
         }
     }
 
-    void make_filepath(SkString* path, const SkString& dir, const SkString& name) {
-        size_t len = dir.size();
-        path->set(dir);
-        if (0 < len  && '/' != dir[len - 1]) {
-            path->append("/");
-        }
-        path->append(name);
-    }
-
     bool is_percentage(const char* const string) {
         SkString skString(string);
         return skString.endsWith("%");
     }
 
     void setup_bitmap(SkBitmap* bitmap, int width, int height) {
         bitmap->allocN32Pixels(width, height);
         bitmap->eraseColor(SK_ColorTRANSPARENT);
     }
 
     bool write_bitmap_to_disk(const SkBitmap& bm, const SkString& dirPath,
                               const char *subdirOrNull, const SkString& baseName) {
         SkString partialPath;
         if (subdirOrNull) {
             partialPath = SkOSPath::SkPathJoin(dirPath.c_str(), subdirOrNull);
             sk_mkdir(partialPath.c_str());
         } else {
             partialPath.set(dirPath);
         }
         SkString fullPath = SkOSPath::SkPathJoin(partialPath.c_str(), baseName.c_str());
         if (SkImageEncoder::EncodeFile(fullPath.c_str(), bm, SkImageEncoder::kPNG_Type, 100)) {
             return true;
         } else {
             SkDebugf("Failed to write the bitmap to %s.\n", fullPath.c_str());
             return false;
         }
     }
 
 } // namespace sk_tools