Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 327393005: System dialog does not need any additional changing of page size. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
Reviewers:
Noam Samuel, scottmg
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

System dialog does not need any additional changing of page size. This change fixed scaling. content_area_in_dpi send to browser process should cover entire page. This fixed shifting of content for system dialog printing. BUG=379961 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276861

Patch Set 1 #

Patch Set 2 : Thu 06/12/2014 2:21:57.86 #

Patch Set 3 : Thu 06/12/2014 2:26:55.73 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -31 lines) Patch
M chrome/renderer/printing/print_web_view_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper_pdf_win.cc View 1 2 6 chunks +4 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-12 09:25:51 UTC) #1
Noam Samuel
lgtm
6 years, 6 months ago (2014-06-12 19:39:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/327393005/40001
6 years, 6 months ago (2014-06-12 19:42:43 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-13 00:05:12 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-13 00:05:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/327393005/40001
6 years, 6 months ago (2014-06-13 00:08:01 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 00:16:09 UTC) #7
Message was sent while issue was closed.
Change committed as 276861

Powered by Google App Engine
This is Rietveld 408576698