Land Recent QUIC Changes.

Land Recent QUIC Changes.

(This CL merges changes until last Friday).

Change the QUIC TLP to send new data instead of retransmitting old data
when new data is available.

Also tighten up the QuicSentPacketManagerTest for TLP per avd's request.

Merge internal change: 68731782
https://codereview.chromium.org/327383002/


Use override consistently instead of virtual.

Merge internal change: 68717267
https://codereview.chromium.org/325373002/


QUIC - added code to read kUAID in the server code from the CHLO
message.

The following is the list of kUAID strings for chrome built by google.

The following is true for all platforms for clients built by
google (android, posix, windows and chromeos).

UAID: "unknown Chrome/37.0.2029.0" chrome developer's builds.
UAID: " Chrome/37.0.2029.0"        Stable
UAID: "canary Chrome/37.0.2029.0"  Canary
UAID: "dev Chrome/37.0.2029.0"     Dev
UAID: "beta Chrome/37.0.2029.0"    Beta

Merge internal change: 68715745
https://codereview.chromium.org/333523002/


Minor change to keep the code similar between chromium and internal
source tree.

+ use SupportedVersions.
+ One line per argument.
+ Minor fixes to comments.

Merge internal change: 68659711
https://codereview.chromium.org/335433002/


Changed  SetIpInfoInCmsg to return the length of the packet info
structure used.

Merge internal change: 68639530
https://codereview.chromium.org/329223003/


(minor) rename frames_ to buffered_frames_ in QuicStreamSequencer

Merge internal change: 68571729
https://codereview.chromium.org/329403003/


Enables PacketGenerator's use of PacketCreator's FEC primitives.

Adds methods in PacketGenerator that enable use of the PacketCreator's
FEC primitives, and adds tests for these methods.

Merge internal change: 68558082
https://codereview.chromium.org/326403006/


Connection level flow control (CLFC) accounting on receipt of FIN/RST
for already closed streams.

This implements the following behavior discussed internally.

  Proposal: implement rch/jar's solution from earlier in the thread, in
  which "bytes sent" is added to the RST frame, and each endpoint must
  send a FIN or RST containing "bytes sent" on stream termination.

  This gets the job done pretty simply, and will make our flow control
  very similar to SPDY. We can investigate more exotic dynamic stream
  window scaling (as per avd's suggestion earlier in the thread) in
  future if SPDY-style flow control is shown to be a problem.

A stream *must* send either a FIN or a RST on termination, either of
which contain enough data that the peer can definitively determine how
many bytes were sent on that stream (this is already implemented). This
CL implements the correct CLFC accounting of these frames when received
after the stream has been closed locally.

Motivating example: Client sends GET+FIN, Server sends response. Before
response arrives, client RSTs the stream (user closed tab?), tearing
down local state. Before this CL, when the server response arrives it
just gets dropped - but the server has counted the bytes sent against
its CLFC _send_ window. The client will not count these bytes against
it's CLFC _receive_ window, and so the endpoint states are now out of
sync.

To fix this, when a stream is closed we store the current "last bytes
received offset" in a map in the session, and handle a FIN/RST for a
closed stream by removing the difference between the final byte offset
from FIN/RST and the stored value from the map to the CLFC receive
window.

QUIC: Connection level flow control accounting on receipt of FIN/RST for
already closed streams. Protected behind existing flag:
FLAGS_enable_quic_connection_flow_control

Merge internal change: 68555475
https://codereview.chromium.org/320263003/


Add QuicStreamSequencerPeer to quic/test_tools, to make stream sequencer
tests more consistent with other tests.

Merge internal change: 68553409
https://codereview.chromium.org/318333002/

R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276575

[Ryan Hamilton, 2014-06-12 00:43:19]

lgtm

[ramant (doing other things), 2014-06-12 00:46:15]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:47:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/327393002/20001

[commit-bot: I haz the power, 2014-06-12 08:02:53]

Change committed as 276575