Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 327363002: Remove adview (Closed)

Created:
6 years, 6 months ago by Fady Samuel
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove adview To simplify the <appview> upstreaming effort, this CL removes <adview>. BUG=364141 TBR=sky@chromium.org for chrome/renderer/chrome_content_renderer_client.cc chrome/renderer/resources/renderer_resources.grd Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277076

Patch Set 1 #

Total comments: 8

Patch Set 2 : More files deleted! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1145 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/apps/ad_view_browsertest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/guest_view/ad_view/ad_view_constants.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/guest_view/ad_view/ad_view_constants.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/guest_view/ad_view/ad_view_guest.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/guest_view/ad_view/ad_view_guest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/common/extensions/api/adview.json View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/webview_tag.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/known_broken_links.json View 1 4 chunks +1 line, -4 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 4 chunks +3 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
D chrome/renderer/resources/extensions/ad_view.js View 1 chunk +0 lines, -395 lines 0 comments Download
D chrome/renderer/resources/extensions/ad_view_deny.js View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/stubs_app/manifest.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/ad_network_site/ads/image315.png View 1 Binary file 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/ad_network_site/testsdk.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/ad_network_site/testsdk.js View 1 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/flag_required/chrometest.js View 1 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/flag_required/index.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/flag_required/main.js View 1 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/flag_required/manifest.json View 1 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/chrometest.js View 1 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/index.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/main.js View 1 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/manifest.json View 1 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/properties_exposed/chrometest.js View 1 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/properties_exposed/index.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/properties_exposed/main.js View 1 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/ad_view/properties_exposed/manifest.json View 1 1 chunk +0 lines, -14 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/renderer/resources/platform_app.css View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Fady Samuel
6 years, 6 months ago (2014-06-11 22:23:13 UTC) #1
lazyboy
There are other stuffs that needs delete too: kAdviewTagName from chrome_content_renderer_client.cc adview permission from _api_features.json ...
6 years, 6 months ago (2014-06-11 22:34:00 UTC) #2
Fady Samuel
More cleanup! https://codereview.chromium.org/327363002/diff/1/chrome/browser/apps/ad_view_browsertest.cc File chrome/browser/apps/ad_view_browsertest.cc (left): https://codereview.chromium.org/327363002/diff/1/chrome/browser/apps/ad_view_browsertest.cc#oldcode33 chrome/browser/apps/ad_view_browsertest.cc:33: "platform_apps/ad_view/properties_exposed")) << message_; On 2014/06/11 22:33:59, lazyboy ...
6 years, 6 months ago (2014-06-12 20:53:31 UTC) #3
lazyboy
lgtm
6 years, 6 months ago (2014-06-12 21:24:34 UTC) #4
Fady Samuel
+kalman@ for OWNER approval
6 years, 6 months ago (2014-06-12 21:25:55 UTC) #5
not at google - send to devlin
6 years, 6 months ago (2014-06-12 22:18:55 UTC) #6
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-12 22:19:11 UTC) #7
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-06-12 22:24:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/327363002/20001
6 years, 6 months ago (2014-06-12 22:27:49 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 04:40:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 04:46:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/73504)
6 years, 6 months ago (2014-06-13 04:46:29 UTC) #12
Fady Samuel
+sky@ for OWNER review of: chrome/renderer/chrome_content_renderer_client.cc chrome/renderer/resources/renderer_resources.grd
6 years, 6 months ago (2014-06-13 14:57:28 UTC) #13
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-06-13 20:04:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/327363002/20001
6 years, 6 months ago (2014-06-13 20:07:13 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 20:16:05 UTC) #16
Message was sent while issue was closed. 
Change committed as 277076

Powered by Google App Engine
This is Rietveld 408576698