[SyncFS] Create FakeSyncWorker class

[SyncFS] Create FakeSyncWorker class

BUG=378621
TEST=successful build

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277368

[peria, 2014-06-12 07:17:21]

PTL.

[tzik, 2014-06-12 07:47:59]

https://codereview.chromium.org/327323006/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/327323006/diff/1/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:2345:
'browser/sync_file_system/drive_backend/fake_sync_worker.h',
Please move them to chrome_test_unit.gypi.

[tzik, 2014-06-12 07:54:52]

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc (right):

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc:44:
weak_ptr_factory_.GetWeakPtr()));
Can we drop MetadataDatabase dependency from this class?

[nhiroki, 2014-06-12 08:00:09]

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc (right):

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc:77: void
FakeSyncWorker::UninstallOrigin(const GURL& origin,
You may want to record uninstalled origins like Registered/Enabled/Disabled
origins? For example,

enum AppStatus {
  REGISTERED,
  ENABLED,
  DISABLED,
  UNINSTALLED,
};
std::map<GURL, AppStatus> status_map_;

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h (right):

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h:66: // See
RemoteFileSyncService for the details.
I think you don't have to repeat these comments written in SyncWorkerInterface.
How about putting "// SyncWorkerInterface overrides." instead?

[peria, 2014-06-12 10:49:31]

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc (right):

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc:44:
weak_ptr_factory_.GetWeakPtr()));
On 2014/06/12 07:54:52, tzik wrote:
> Can we drop MetadataDatabase dependency from this class?

Done.

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc:77: void
FakeSyncWorker::UninstallOrigin(const GURL& origin,
On 2014/06/12 08:00:08, nhiroki wrote:
> You may want to record uninstalled origins like Registered/Enabled/Disabled
> origins? For example,
> 
> enum AppStatus {
>   REGISTERED,
>   ENABLED,
>   DISABLED,
>   UNINSTALLED,
> };
> std::map<GURL, AppStatus> status_map_;

Done.

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h (right):

https://codereview.chromium.org/327323006/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h:66: // See
RemoteFileSyncService for the details.
On 2014/06/12 08:00:08, nhiroki wrote:
> I think you don't have to repeat these comments written in
SyncWorkerInterface.
> How about putting "// SyncWorkerInterface overrides." instead?

Done.

https://codereview.chromium.org/327323006/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/327323006/diff/1/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:2345:
'browser/sync_file_system/drive_backend/fake_sync_worker.h',
On 2014/06/12 07:47:59, tzik wrote:
> Please move them to chrome_test_unit.gypi.

Done.

[tzik, 2014-06-13 02:26:15]

lgtm

https://codereview.chromium.org/327323006/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h (right):

https://codereview.chromium.org/327323006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h:38: class Env;
Can we remove this?

https://codereview.chromium.org/327323006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h:125:
base::WeakPtrFactory<FakeSyncWorker> weak_ptr_factory_;
not used?/is not going to used?

[peria, 2014-06-13 02:34:47]

+ Removed UpdateServiceStateForTesting
+ Add the behavior of SetSyncEnabled()

https://codereview.chromium.org/327323006/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h (right):

https://codereview.chromium.org/327323006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h:38: class Env;
On 2014/06/13 02:26:15, tzik wrote:
> Can we remove this?

Done.

https://codereview.chromium.org/327323006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h:125:
base::WeakPtrFactory<FakeSyncWorker> weak_ptr_factory_;
On 2014/06/13 02:26:15, tzik wrote:
> not used?/is not going to used?

Seems not to be needed.
Removed.

[nhiroki, 2014-06-13 03:59:59]

lgtm

[peria, 2014-06-13 04:05:51]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-06-13 04:09:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/327323006/120001

[commit-bot: I haz the power, 2014-06-13 12:24:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-13 12:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 12:33:47]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[peria, 2014-06-13 13:40:31]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-06-13 13:41:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/327323006/120001

[commit-bot: I haz the power, 2014-06-13 14:54:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-13 15:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 15:22:25]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[peria, 2014-06-16 03:03:05]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-06-16 03:03:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/327323006/160001

[commit-bot: I haz the power, 2014-06-16 07:14:48]

Change committed as 277368