Introduce use counters for Blink specific CSS classes for editing

Introduce use counters for Blink specific CSS classes for editing

This patch introduces Blink specific CSS classes for editing for
  - Apple-interchange-newline
  - Apple-converted-space
  - Apple-paste-as-quotation
  - Apple-style-span
  - Apple-tab-span
These CSS classes are defined in "core/editing/HTMLInterchange.h"

We would like to deprecate these Blink specific CSS classes for browser
compatibility, if possible.

BUG=383677
TEST=n/a

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176171

[yosin_UTC9, 2014-06-12 03:23:57]

Could you review this patch?
Thanks in advance.

[yosin_UTC9, 2014-06-12 03:23:58]

Could you review this patch?
Thanks in advance.

[Yuta Kitamura, 2014-06-12 07:55:23]

Generally looks okay, I have just one thing I'd like to ask.

https://codereview.chromium.org/327323005/diff/1/Source/core/editing/ReplaceS...
File Source/core/editing/ReplaceSelectionCommand.cpp (right):

https://codereview.chromium.org/327323005/diff/1/Source/core/editing/ReplaceS...
Source/core/editing/ReplaceSelectionCommand.cpp:293:
UseCounter::count(node->document(), UseCounter::EditingAppleInterchangeNewline);
You add some count() calls in predicate functions named
isXXXXNode(), while some in other places (like here).

I'm okay with putting count() calls in either types of
places (inside predicate functions vs use site of
predicate functions), but at least I'd like them to be
placed in a consistent manner.

[yosin_UTC9, 2014-06-12 08:46:06]

PTAL

https://chromiumcodereview.appspot.com/327323005/diff/1/Source/core/editing/R...
File Source/core/editing/ReplaceSelectionCommand.cpp (right):

https://chromiumcodereview.appspot.com/327323005/diff/1/Source/core/editing/R...
Source/core/editing/ReplaceSelectionCommand.cpp:293:
UseCounter::count(node->document(), UseCounter::EditingAppleInterchangeNewline);
On 2014/06/12 07:55:23, Yuta Kitamura wrote:
> You add some count() calls in predicate functions named
> isXXXXNode(), while some in other places (like here).
> 
> I'm okay with putting count() calls in either types of
> places (inside predicate functions vs use site of
> predicate functions), but at least I'd like them to be
> placed in a consistent manner.
You're right. I move count() call to predicate.

[yosin_UTC9, 2014-06-13 08:31:05]

ping

[yosin_UTC9, 2014-06-13 08:49:13]

ping

[Yuta Kitamura, 2014-06-16 02:47:43]

LGTM but you probably need to renumber your UseCounter enums
since new metric items have been added.

[yosin_UTC9, 2014-06-16 03:35:40]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2014-06-16 03:36:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yosin@chromium.org/327323005/60001

[commit-bot: I haz the power, 2014-06-16 04:44:24]

Change committed as 176171