Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 327293002: Add missing member initialization in AppWindow::CreateParams. (Closed)

Created:
6 years, 6 months ago by earthdok
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add missing member initialization in AppWindow::CreateParams. MemorySanitizer complained when those values were sent over IPC. BUG=383363 R=kalman@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M apps/app_window.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
earthdok
ptal
6 years, 6 months ago (2014-06-11 15:41:20 UTC) #1
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-11 16:33:42 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 6 months ago (2014-06-11 16:34:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/327293002/1
6 years, 6 months ago (2014-06-11 16:37:41 UTC) #4
earthdok
The CQ bit was unchecked by earthdok@chromium.org
6 years, 6 months ago (2014-06-11 18:22:02 UTC) #5
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 6 months ago (2014-06-11 18:22:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/327293002/1
6 years, 6 months ago (2014-06-11 18:24:25 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 18:28:23 UTC) #8
Message was sent while issue was closed.
Change committed as 276462

Powered by Google App Engine
This is Rietveld 408576698