Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 327273005: Revert of Use labels to display views tab titles. (Closed)

Created:
6 years, 6 months ago by please use gerrit instead
Modified:
6 years, 6 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert of Use labels to display views tab titles. (https://codereview.chromium.org/323993002/) Reason for revert: Appears to have a memory leak. See: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/3954 Original issue's description: > Use labels to display views tab titles. > > Add a Label view to Tab for displaying the title. > Remove Tab::PaintTitle, bounds and font members. > Remove unnecessary Tab::Get[Title|Icon]Bounds helpers. > Update the text on Tab::SetData, not during paint. > Use gfx::DirectionalityMode, remove the Label enum. > > Add gfx::ALIGN_TO_HEAD to gfx::HorizontalAlignment. > Add Label::GetHorizontalAlignment for ALIGN_TO_HEAD. > Always flip left/right in Label::SetHorizontalAlignment. > Have Tab and MessageBoxView use ALIGN_TO_HEAD. > > Update comments and tests, related minor cleanup. > > TODO: Make Label cache RenderText objects. > TODO: Make RenderText support ALIGN_TO_HEAD. > > BUG=240037 > TEST=No visible Views tab title changes. > R=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276450 TBR=sky@chromium.org,msw@chromium.org NOTREECHECKS=true NOTRY=true BUG=240037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -177 lines) Patch
M chrome/browser/ui/views/tabs/tab.h View 6 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 17 chunks +64 lines, -41 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/validation_message_bubble_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/text_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/bounded_label.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label.h View 4 chunks +48 lines, -13 lines 0 comments Download
M ui/views/controls/label.cc View 7 chunks +24 lines, -32 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 16 chunks +65 lines, -67 lines 0 comments Download
M ui/views/controls/message_box_view.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Created Revert of Use labels to display views tab titles.
6 years, 6 months ago (2014-06-11 19:27:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/327273005/1
6 years, 6 months ago (2014-06-11 19:28:50 UTC) #2
commit-bot: I haz the power
Change committed as 276476
6 years, 6 months ago (2014-06-11 19:33:56 UTC) #3
msw
6 years, 6 months ago (2014-06-11 19:57:47 UTC) #4
Message was sent while issue was closed.
lgtm, ty.

Powered by Google App Engine
This is Rietveld 408576698