google_apis/gcm/engine/gcm_store_impl.cc - Issue 327263003: Fix the DCHECK failure when starting and stopping GCMClient immediately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/gcm_store_impl.cc

Issue 327263003: Fix the DCHECK failure when starting and stopping GCMClient immediately (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/engine/gcm_store_impl.cc

diff --git a/google_apis/gcm/engine/gcm_store_impl.cc b/google_apis/gcm/engine/gcm_store_impl.cc

index 8c6f730f43b274624db810e3a05ef7078cb312a0..e27e82e6ce273b4fa8f2805185e4b29364418801 100644

--- a/google_apis/gcm/engine/gcm_store_impl.cc

+++ b/google_apis/gcm/engine/gcm_store_impl.cc

@@ -727,6 +727,8 @@ void GCMStoreImpl::Load(const LoadCallback& callback) {

}

void GCMStoreImpl::Close() {

+ weak_ptr_factory_.InvalidateWeakPtrs();

+ app_message_counts_.clear();

blocking_task_runner_->PostTask(

FROM_HERE,

base::Bind(&GCMStoreImpl::Backend::Close, backend_));

« no previous file with comments | « components/gcm_driver/gcm_client_impl_unittest.cc ('k') | no next file » | no next file with comments »