components/gcm_driver/gcm_client_impl.cc - Issue 327263003: Fix the DCHECK failure when starting and stopping GCMClient immediately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client_impl.cc

Issue 327263003: Fix the DCHECK failure when starting and stopping GCMClient immediately (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/gcm_client_impl.cc

diff --git a/components/gcm_driver/gcm_client_impl.cc b/components/gcm_driver/gcm_client_impl.cc

index a60df6915aa6b0a0284de79c377f55420c2bcb75..6560342bdfe827c4c94117763d34ac0e50557db9 100644

--- a/components/gcm_driver/gcm_client_impl.cc

+++ b/components/gcm_driver/gcm_client_impl.cc

@@ -502,6 +502,7 @@ void GCMClientImpl::UpdateRegistrationCallback(bool success) {

}

void GCMClientImpl::Stop() {

+ weak_ptr_factory_.InvalidateWeakPtrs();

device_checkin_info_.Reset();

connection_factory_.reset();

mcs_client_.reset();

« no previous file with comments | « no previous file | components/gcm_driver/gcm_client_impl_unittest.cc » ('j') | no next file with comments »