Source/platform/fonts/mac/ComplexTextController.cpp - Issue 327243005: Remove GlyphBufferAdvance abstraction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/mac/ComplexTextController.cpp

Issue 327243005: Remove GlyphBufferAdvance abstraction. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase again Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/mac/ComplexTextController.cpp

diff --git a/Source/platform/fonts/mac/ComplexTextController.cpp b/Source/platform/fonts/mac/ComplexTextController.cpp

index 7bcd8008a8dd4d8fd417de8de9031e34e227ec1b..75353ad5c12d70c4813b20105554011afe3e2c74 100644

--- a/Source/platform/fonts/mac/ComplexTextController.cpp

+++ b/Source/platform/fonts/mac/ComplexTextController.cpp

@@ -470,7 +470,7 @@ void ComplexTextController::advance(unsigned offset, GlyphBuffer* glyphBuffer, G

return;

if (glyphBuffer && !m_characterInCurrentGlyph)

- glyphBuffer->add(m_adjustedGlyphs[k], complexTextRun.fontData(), adjustedAdvance);

+ glyphBuffer->add(m_adjustedGlyphs[k], complexTextRun.fontData(), FloatSize(adjustedAdvance));

unsigned oldCharacterInCurrentGlyph = m_characterInCurrentGlyph;

m_characterInCurrentGlyph = min(m_currentCharacter - complexTextRun.stringLocation(), glyphEndOffset) - glyphStartOffset;