Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp - Issue 327243005: Remove GlyphBufferAdvance abstraction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp

Issue 327243005: Remove GlyphBufferAdvance abstraction. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase again Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp

diff --git a/Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp b/Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp

index e0c466650f17d1b4b2a1bec8214f5f0a16527d8f..d9d77dbc443e651032732d6bd32dedff0287798d 100644

--- a/Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp

+++ b/Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp

@@ -153,7 +153,7 @@ void Font::drawGlyphs(GraphicsContext* gc, const SimpleFontData* font,

// text drawing can proceed faster. However, it's unclear when those

// patches may be upstreamed to WebKit so we always use the slower path

// here.

- const GlyphBufferAdvance* adv = glyphBuffer.advances(from);

+ const FloatSize* adv = glyphBuffer.advances(from);

for (unsigned i = 0; i < numGlyphs; i++) {

pos[i].set(x, y);

x += SkFloatToScalar(adv[i].width());