Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: components/invalidation/p2p_invalidation_service.h

Issue 327243003: Introduce ProfileInvalidationProvider wrapper for InvalidationService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/invalidation/invalidation_service.h ('k') | components/invalidation/p2p_invalidation_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/p2p_invalidation_service.h
diff --git a/components/invalidation/p2p_invalidation_service.h b/components/invalidation/p2p_invalidation_service.h
index 94276b74bac90dabe903814ba2539fc0a3a20914..a2b600b4f84902d5787a1247148035404018b905 100644
--- a/components/invalidation/p2p_invalidation_service.h
+++ b/components/invalidation/p2p_invalidation_service.h
@@ -27,9 +27,8 @@ class InvalidationLogger;
// This service is a wrapper around P2PInvalidator. Unlike other
// InvalidationServices, it can both send and receive invalidations. It is used
// only in tests, where we're unable to connect to a real invalidations server.
-class P2PInvalidationService
- : public base::NonThreadSafe,
- public InvalidationService {
+class P2PInvalidationService : public base::NonThreadSafe,
+ public InvalidationService {
public:
P2PInvalidationService(
scoped_ptr<IdentityProvider> identity_provider,
@@ -37,11 +36,8 @@ class P2PInvalidationService
syncer::P2PNotificationTarget notification_target);
virtual ~P2PInvalidationService();
- // Overrides KeyedService method.
- virtual void Shutdown() OVERRIDE;
-
// InvalidationService implementation.
- // It is an error to have registered handlers when Shutdown() is called.
+ // It is an error to have registered handlers when the service is destroyed.
virtual void RegisterInvalidationHandler(
syncer::InvalidationHandler* handler) OVERRIDE;
virtual void UpdateRegisteredInvalidationIds(
« no previous file with comments | « components/invalidation/invalidation_service.h ('k') | components/invalidation/p2p_invalidation_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698