Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: components/invalidation/invalidation_service.h

Issue 327243003: Introduce ProfileInvalidationProvider wrapper for InvalidationService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/invalidation.gypi ('k') | components/invalidation/p2p_invalidation_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/invalidation_service.h
diff --git a/components/invalidation/invalidation_service.h b/components/invalidation/invalidation_service.h
index 7b6f3cdb49a8df75b1c3a1825bfeadbe5fee75e2..cc7613d0997a89cd12c9510dca4c21d0d7de2a08 100644
--- a/components/invalidation/invalidation_service.h
+++ b/components/invalidation/invalidation_service.h
@@ -6,7 +6,6 @@
#define COMPONENTS_INVALIDATION_INVALIDATION_SERVICE_H_
#include "base/callback_forward.h"
-#include "components/keyed_service/core/keyed_service.h"
#include "sync/internal_api/public/base/invalidator_state.h"
#include "sync/notifier/invalidation_util.h"
@@ -64,12 +63,10 @@ class InvalidationLogger;
// NOTE(akalin): Invalidations that come in during browser shutdown may get
// dropped. This won't matter once we have an Acknowledge API, though: see
// http://crbug.com/78462 and http://crbug.com/124149.
-//
-// This class inherits from ProfileKeyedService to make it possible to correctly
-// cast from various InvalidationService implementations to ProfileKeyedService
-// in InvalidationServiceFactory.
-class InvalidationService : public KeyedService {
+class InvalidationService {
public:
+ virtual ~InvalidationService() {}
+
// Starts sending notifications to |handler|. |handler| must not be NULL,
// and it must not already be registered.
//
@@ -112,9 +109,6 @@ class InvalidationService : public KeyedService {
// Returns the identity provider.
virtual IdentityProvider* GetIdentityProvider() = 0;
-
- protected:
- virtual ~InvalidationService() { }
};
} // namespace invalidation
« no previous file with comments | « components/invalidation.gypi ('k') | components/invalidation/p2p_invalidation_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698