|
Introduce ProfileInvalidationProvider wrapper for InvalidationService
TiclInvalidationService was refactored to no longer depend on Profile.
However, it still is a KeyedService. While this does actually pull in
Profile as a dependency, it implies that TiclInvalidationService should
be considered a per-Profile service, like the other KeyedServices in
Chrome's code base.
This CL introduces ProfileInvalidationProvider, a KeyedService that is a
tiny wrapper around an InvalidationService. Given this wrapper,
InvalidationService (and with it, TiclInvalidationService) no longer have
to be KeyedServices.
BUG= 362083
TEST=Updated unit and browser tests
TBR=dcheng (chrome/browser/extensions/api/push_messaging/*)
TBR=davemoore (chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc)
TBR=arv (chrome/browser/ui/webui/invalidations_message_handler.cc)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276715
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+497 lines, -532 lines) |
Patch |
 |
M |
chrome/browser/drive/DEPS
|
View
|
1
2
3
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/drive/drive_notification_manager.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/drive/drive_notification_manager_factory.cc
|
View
|
1
2
3
|
3 chunks |
+10 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
|
View
|
1
2
3
|
7 chunks |
+30 lines, -24 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc
|
View
|
1
2
3
|
5 chunks |
+19 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/fake_invalidation_service.h
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/fake_invalidation_service.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/invalidation_service_android_unittest.cc
|
View
|
1
|
4 chunks |
+4 lines, -9 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/invalidation/invalidation_service_factory.h
|
View
|
|
1 chunk |
+0 lines, -66 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/invalidation/invalidation_service_factory.cc
|
View
|
|
1 chunk |
+0 lines, -145 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/invalidation/invalidation_service_factory_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -123 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/invalidation/profile_invalidation_provider_factory.h
|
View
|
|
1 chunk |
+65 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/invalidation/profile_invalidation_provider_factory.cc
|
View
|
1
2
3
|
8 chunks |
+21 lines, -17 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/invalidation/profile_invalidation_provider_factory_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+127 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/ticl_invalidation_service.h
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/ticl_invalidation_service.cc
|
View
|
|
2 chunks |
+6 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/ticl_invalidation_service_unittest.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/policy/cloud/cloud_policy_browsertest.cc
|
View
|
1
2
3
|
4 chunks |
+20 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/policy/cloud/user_cloud_policy_invalidator.cc
|
View
|
1
2
3
|
2 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/policy/cloud/user_cloud_policy_invalidator_factory.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
|
View
|
1
2
3
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service.cc
|
View
|
1
2
3
|
3 chunks |
+10 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_factory.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
|
View
|
1
2
3
|
5 chunks |
+16 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_unittest.cc
|
View
|
1
2
3
|
5 chunks |
+16 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test/integration/fake_server_invalidation_service.h
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test/integration/fake_server_invalidation_service.cc
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test/integration/sync_test.cc
|
View
|
1
2
3
|
6 chunks |
+39 lines, -22 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test_profile_sync_service.cc
|
View
|
1
2
3
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/invalidations_message_handler.cc
|
View
|
1
2
3
|
3 chunks |
+14 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests.gypi
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/invalidation.gypi
|
View
|
1
2
3
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/invalidation/invalidation_service.h
|
View
|
|
3 chunks |
+3 lines, -9 lines |
0 comments
|
Download
|
 |
M |
components/invalidation/p2p_invalidation_service.h
|
View
|
|
2 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
 |
M |
components/invalidation/p2p_invalidation_service.cc
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
A |
components/invalidation/profile_invalidation_provider.h
|
View
|
1
2
3
|
1 chunk |
+37 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/invalidation/profile_invalidation_provider.cc
|
View
|
1
2
3
|
1 chunk |
+27 lines, -0 lines |
0 comments
|
Download
|
Total messages: 14 (0 generated)
|